Bug 233055 - archivers/cabextract: enforces link with native iconv
Summary: archivers/cabextract: enforces link with native iconv
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Sunpoet Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-11-07 11:20 UTC by Lorenzo Salvadore
Modified: 2018-11-10 08:01 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (sunpoet)


Attachments
patch with USES+= iconv (485 bytes, patch)
2018-11-07 11:20 UTC, Lorenzo Salvadore
phascolarctos: maintainer-approval? (sunpoet)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Lorenzo Salvadore 2018-11-07 11:20:35 UTC
Created attachment 199047 [details]
patch with USES+= iconv

The actual version of cabextract links with ${LOCALBASE}/libiconv.so.2 if and only if converters/libiconv is installed and this (conditional) dependency is never declared in cabextract's Makefile.

My patch just adds iconv to the USES flags, which has as consequence to enforce link with the native iconv (i.e. cabextract is linked only to libc).

All supported release have a native iconv since 10-CURRENT, so there are no special cases that need to link with libiconv from ports.

I tested the patch in a 11.2-RELEASE/amd64 jail and on poudriere (11.2-RELEASE, both on amd64 and i386).
Comment 1 commit-hook freebsd_committer 2018-11-10 07:59:42 UTC
A commit references this bug:

Author: sunpoet
Date: Sat Nov 10 07:59:09 UTC 2018
New revision: 484591
URL: https://svnweb.freebsd.org/changeset/ports/484591

Log:
  Register iconv dependency

  - Bump PORTREVISION for dependency and package change

  PR:		233055
  Submitted by:	Lorenzo Salvadore <phascolarctos@protonmail.ch>

Changes:
  head/archivers/cabextract/Makefile
Comment 2 Sunpoet Po-Chuan Hsieh freebsd_committer 2018-11-10 08:01:22 UTC
Committed. Thanks!