Bug 233064 - x11/gnome-session - build fails: Missing Dependency dbus-glib-1 in poudriere
Summary: x11/gnome-session - build fails: Missing Dependency dbus-glib-1 in poudriere
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: freebsd-gnome (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-11-08 00:29 UTC by Robert Zelaya
Modified: 2018-11-10 19:17 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (gnome)


Attachments
add dbus-glib to Makefile (414 bytes, patch)
2018-11-08 00:29 UTC, Robert Zelaya
no flags Details | Diff
corrected-patch (459 bytes, patch)
2018-11-08 18:07 UTC, Walter Schwarzenfeld
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Zelaya 2018-11-08 00:29:47 UTC
Created attachment 199068 [details]
add dbus-glib to Makefile

gnome-session fails to build on poudriere

ERROR:
meson.build:152:4: ERROR:  Dependency "dbus-glib-1" not found, tried pkgconfig

Fix:
Add dependaency libdbus-glib-1.so:devel/dbus-glib to gnome-session Makefile
Comment 1 Walter Schwarzenfeld freebsd_triage 2018-11-08 15:39:43 UTC
The "usual" way is:
 LIB_DEPENDS=	libjson-glib-1.0.so:devel/json-glib \
-		libepoxy.so:graphics/libepoxy 
+		libepoxy.so:graphics/libepoxy \
+              libdbus-glib-1.so:devel/dbus-glib
Comment 2 Walter Schwarzenfeld freebsd_triage 2018-11-08 18:07:28 UTC
Created attachment 199083 [details]
corrected-patch

I had to add to the Makefile

+post-configure:
+	 ${REINPLACE_CMD} 's|xhtml-nochunks|--skip-validation xhtml-nochunks|' ${WRKSRC}/_build/build.ninja
+

cause of:

FAILED: doc/dbus/gnome-session.html 
/usr/local/bin/xmlto xhtml-nochunks -o /ram/home/ngorx/temp/gnome-session/work/gnome-session-3.28.1/_build/doc/dbus -m ../doc/dbus/config.xsl doc/dbus/gnome-session.xml
xmlto: /ram/home/ngorx/temp/gnome-session/work/gnome-session-3.28.1/_build/doc/dbus/gnome-session.xml does not validate (status 3)
xmlto: Fix document syntax or use --skip-validation option
I/O error : Attempt to load network entity http://www.oasis-open.org/docbook/xml/4.1.2/docbookx.dtd
/ram/home/ngorx/temp/gnome-session/work/gnome-session-3.28.1/_build/doc/dbus/gnome-session.xml:8: warning: failed to load external entity "http://www.oasis-open.org/docbook/xml/4.1.2/docbookx.dtd"
]>
  ^
I/O error : Attempt to load network entity http://www.oasis-open.org/docbook/xml/4.1.2/docbookx.dtd
warning: failed to load external entity "http://www.oasis-open.org/docbook/xml/4.1.2/docbookx.dtd"
validity error : Could not load the external subset "http://www.oasis-open.org/docbook/xml/4.1.2/docbookx.dtd"
Document /ram/home/ngorx/temp/gnome-session/work/gnome-session-3.28.1/_build/doc/dbus/gnome-session.xml does not validate
Comment 3 commit-hook freebsd_committer 2018-11-10 10:03:13 UTC
A commit references this bug:

Author: kwm
Date: Sat Nov 10 10:03:06 UTC 2018
New revision: 484597
URL: https://svnweb.freebsd.org/changeset/ports/484597

Log:
  Depend on dbus-glib instead of assuming it present from other ports.

  PR:		233064
  Submitted by:	Robert Zelaya <rob@theseusnetworking.com>

Changes:
  head/x11/gnome-session/Makefile
Comment 4 Koop Mast freebsd_committer 2018-11-10 19:17:03 UTC
Thanks for filing this bug report with the patch, I just changed the lines order a bit.

(In reply to w.schwarzenfeld from comment #2)

This seems to indicate that docbook-xml is not installed, or a problem with those ports. If this is still a problem please open a new bug report.