Bug 233103 - textproc/fcitx-table-other: fix build
Summary: textproc/fcitx-table-other: fix build
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Steve Wills
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-11-10 05:26 UTC by Henry Hu
Modified: 2018-11-10 13:17 UTC (History)
0 users

See Also:


Attachments
patch to fix build (394 bytes, patch)
2018-11-10 05:26 UTC, Henry Hu
henry.hu.sh: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Henry Hu 2018-11-10 05:26:14 UTC
Created attachment 199104 [details]
patch to fix build

Recently, fcitx-table-other cannot be built. The reason seems to be that its build process actually depends on bash, which is missing from its BUILD_DEPENDS. Previously, maybe some of its dependencies depend on bash, but now this dependency must be explicitly specified.
Comment 1 Nathan 2018-11-10 06:45:28 UTC
Comment on attachment 199104 [details]
patch to fix build

Since this is to fix a build, port will need a PORTREVISION bump
Comment 2 Steve Wills freebsd_committer 2018-11-10 13:04:17 UTC
(In reply to Nathan from comment #1)

According to the porters handbook:

https://www.freebsd.org/doc/en/books/porters-handbook/makefile-naming.html

Examples of changes which do not require a PORTREVISION bump:

Build fixes which cause a package to become compilable where it was previously failing. As long as the changes do not introduce any functional change on any other platforms on which the port did previously build. Since PORTREVISION reflects the content of the package, if the package was not previously buildable then there is no need to increase PORTREVISION to mark a change.

So no PORTREVISION bump is needed here.
Comment 3 commit-hook freebsd_committer 2018-11-10 13:16:49 UTC
A commit references this bug:

Author: swills
Date: Sat Nov 10 13:16:06 UTC 2018
New revision: 484610
URL: https://svnweb.freebsd.org/changeset/ports/484610

Log:
  textproc/fcitx-table-other: fix build

  PR:		233103
  Submitted by:	Henry Hu <henry.hu.sh@gmail.com> (maintainer)

Changes:
  head/textproc/fcitx-table-other/Makefile
Comment 4 Steve Wills freebsd_committer 2018-11-10 13:17:37 UTC
Committed, thanks!