Bug 233192 - games/anki: Update to 2.1.11
Summary: games/anki: Update to 2.1.11
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kai Knoblich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-11-13 08:51 UTC by Kai Knoblich
Modified: 2019-03-29 16:39 UTC (History)
3 users (show)

See Also:


Attachments
anki-2.1.5.patch (71.87 KB, patch)
2018-11-13 08:51 UTC, Kai Knoblich
kai: maintainer-approval+
Details | Diff
anki-2.1.5-v2.patch (71.88 KB, patch)
2018-11-14 07:16 UTC, Kai Knoblich
kai: maintainer-approval-
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kai Knoblich freebsd_committer freebsd_triage 2018-11-13 08:51:18 UTC
Created attachment 199199 [details]
anki-2.1.5.patch

Hello,

attached is the patch that updates games/anki to 2.1.5

Changes by upstream:
- https://apps.ankiweb.net/docs/changes.html#changes-in-2.1.5

Changes to the port:
- switched from Qt4 to Qt5 as the 2.1.x version only supports the latter one
- upstream's new default player is mpv (but mplayer is also still supported). 
- added OPTIONS to switch between mpv/mplayer
- rebased the patches that place the locale files in to the right dirs
- added patch to enable anki with Qt > 5.10.x

QA:
~~~
- poudriere (11.2-RELEASE, 12.0-BETA4, 13.0-CURRENT@r340055 amd64 + i386) -> OK
- portlint -> OK
Comment 1 Nathan 2018-11-14 03:42:33 UTC
Comment on attachment 199199 [details]
anki-2.1.5.patch

+WRKSRC=	${WRKDIR}/anki-${PORTVERSION}
Doesn't belong under OPTIONS
Comment 2 Kai Knoblich freebsd_committer freebsd_triage 2018-11-14 07:16:22 UTC
Created attachment 199227 [details]
anki-2.1.5-v2.patch

Revised patch which contains WRKSRC at the correct location as suggested by Nathan in comment #1 . Thanks for pointing that out.
Comment 3 Kai Knoblich freebsd_committer freebsd_triage 2018-11-23 07:03:26 UTC
Comment on attachment 199227 [details]
anki-2.1.5-v2.patch

Draw back my approval on the patch since www/py-qt5-webengine has been marked as broken in r485614.

When www/py-qt5-webengine is usable again I'll update the patch.
Comment 4 commit-hook freebsd_committer freebsd_triage 2019-03-13 17:08:43 UTC
A commit references this bug:

Author: kai
Date: Wed Mar 13 17:08:07 UTC 2019
New revision: 495620
URL: https://svnweb.freebsd.org/changeset/ports/495620

Log:
  games/anki: Update to 2.1.11, undeprecate and set to BROKEN

  Undeprecate and save the port from the big Qt4 wipeout by switching from Qt4
  to Qt5.

  Also set games/anki temporarily as BROKEN because www/py-qt5-webengine is
  still in a defunct state. This will change when www/qt5-webengine gets
  updated to a more recent version soon (hopefully to the end of Q1).

  At last but not least: Add options to switch between multimedia/mpv (new
  default by upstream) and multimedia/mplayer (previous default) or choose both
  of them.

  Changelog:

  Notable changes since 2.0.52:

  - Anki 2.1.x uses the same scheduling, syncing and file format as Anki 2.0.x,
    so one can upgrade and downgrade at will.
  - Switched from Python 2.7 to Python 3.6+ and from Qt 4 to Qt 5
  - Add-ons will need to be updated to work with 2.1.
  - Built in MathJax support
  - A "restore backup" option in the profiles screen
  - SVG rendering support for LaTeX
  - Improved add-on configuration, management and updating
  - Night mode for reviewing
  - Improved pasting, with less unnecessary formatting included, and better
    handling of media links.

  https://apps.ankiweb.net/docs/changes.html

  PR:		233192
  Approved by:	miwi (mentor)
  Differential Revision:	https://reviews.freebsd.org/D19564

Changes:
  head/games/anki/Makefile
  head/games/anki/distinfo
  head/games/anki/files/patch-Makefile
  head/games/anki/files/patch-anki_lang.py
  head/games/anki/files/patch-aqt_qt.py
  head/games/anki/pkg-plist
Comment 5 commit-hook freebsd_committer freebsd_triage 2019-03-29 16:37:00 UTC
A commit references this bug:

Author: kai
Date: Fri Mar 29 16:36:46 UTC 2019
New revision: 497168
URL: https://svnweb.freebsd.org/changeset/ports/497168

Log:
  games/anki: Unbreak

  Unbreak since www/py-qt5-webengine is usable again since r497003.

  Also update the patch for aqt/qt.py to load PyQt5.QtWebChannel explicitly.
  Otherwise Anki will crash upon invocation.

  PR:		233192
  Approved by:	mentors (implicit)

Changes:
  head/games/anki/Makefile
  head/games/anki/files/patch-aqt_qt.py