Bug 233221 - [patch] x11-servers/xorg-server: add Intel Iris Plus Graphics 650 PCI ID
Summary: [patch] x11-servers/xorg-server: add Intel Iris Plus Graphics 650 PCI ID
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-x11 mailing list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-11-14 12:49 UTC by Yuri Pankov
Modified: 2019-09-14 19:58 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (x11)


Attachments
add pci id (570 bytes, patch)
2018-11-14 12:49 UTC, Yuri Pankov
no flags Details | Diff
Add PCI IDs to xserver (12.00 KB, patch)
2019-09-10 16:31 UTC, Niclas Zeising
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yuri Pankov freebsd_committer 2018-11-14 12:49:28 UTC
Created attachment 199235 [details]
add pci id

Add Intel Iris Plus Graphics 650 ID to be recognized when using modesetting driver.  The patch is temporary until xorg-server is updated to newer version, which already has the same entry.
Comment 1 Yuri Pankov freebsd_committer 2019-08-30 01:10:27 UTC
Ping?
Comment 2 Niclas Zeising freebsd_committer 2019-08-30 08:48:22 UTC
Hi!
I'm skeptical about this.  There is usually a reason the IDs aren't included, and I feel hesitant to change the default.  When it comes to drivers and hardware support, there's a lot of corner cases and subtleties.
Comment 3 Niclas Zeising freebsd_committer 2019-08-30 08:49:22 UTC
Is this a single upstream commit, or is this addition part of a bigger change?
Comment 4 Yuri Pankov freebsd_committer 2019-08-30 08:58:30 UTC
Looks like it's: https://gitlab.freedesktop.org/xorg/xserver/commit/368f60d461421fe5e2bbd90652d6ac858dbff8fe

It's just one ID to be added, and I have tested it, more so 9 months later :-)
Comment 5 Yuri Pankov freebsd_committer 2019-08-30 09:00:02 UTC
And yes, I can live with this being a local patch until xorg-server is finally updated to newer version.  If there's no one else affected, feel free to close this PR.
Comment 6 Niclas Zeising freebsd_committer 2019-08-30 09:12:31 UTC
I've asked upstream if it's generally safe to backport PCI-ids (they seem to come from mesa, originally).  I'll get back to you once I've gotten a reply.
Comment 7 Yuri Pankov freebsd_committer 2019-08-30 09:13:13 UTC
Thank you!
Comment 8 Niclas Zeising freebsd_committer 2019-09-10 16:31:23 UTC
Created attachment 207350 [details]
Add PCI IDs to xserver

According to upstream, it should be packport PCI IDs from later xserver versions.  The worst case would be that it loads but fails to initialize the MESA DRI driver, and then fall back to software rendering or something, but that's already the case.

I've attached a patch to update the PCI IDs, please give it a spin.
Comment 9 Yuri Pankov freebsd_committer 2019-09-10 22:40:23 UTC
Works for me, thanks!

[   432.916] (==) modeset(0): Backing store enabled
[   432.916] (==) modeset(0): Silken mouse enabled
[   432.916] (II) modeset(0): RandR 1.2 enabled, ignore the following RandR disabled message.
[   432.988] (==) modeset(0): DPMS enabled
[   432.988] (II) modeset(0): [DRI2] Setup complete
[   432.988] (II) modeset(0): [DRI2]   DRI driver: i965
[   432.988] (II) modeset(0): [DRI2]   VDPAU driver: i965
[   433.038] (--) RandR disabled
[   433.046] (II) AIGLX: enabled GLX_MESA_copy_sub_buffer
[   433.046] (II) AIGLX: enabled GLX_ARB_create_context
[   433.046] (II) AIGLX: enabled GLX_ARB_create_context_profile
[   433.046] (II) AIGLX: enabled GLX_EXT_create_context_es{,2}_profile
[   433.046] (II) AIGLX: enabled GLX_INTEL_swap_event
[   433.046] (II) AIGLX: enabled GLX_SGI_swap_control and GLX_MESA_swap_control
[   433.046] (II) AIGLX: enabled GLX_EXT_framebuffer_sRGB
[   433.046] (II) AIGLX: enabled GLX_ARB_fbconfig_float
[   433.046] (II) AIGLX: enabled GLX_EXT_fbconfig_packed_float
[   433.046] (II) AIGLX: GLX_EXT_texture_from_pixmap backed by buffer objects
[   433.046] (II) AIGLX: enabled GLX_ARB_create_context_robustness
[   433.046] (II) AIGLX: Loaded and initialized i965
[   433.046] (II) GLX: Initialized DRI2 GL provider for screen 0
[   433.198] (II) modeset(0): Damage tracking initialized
[   433.198] (II) modeset(0): Setting screen physical size to 1016 x 571
Comment 10 commit-hook freebsd_committer 2019-09-14 19:55:44 UTC
A commit references this bug:

Author: zeising
Date: Sat Sep 14 19:55:24 UTC 2019
New revision: 512052
URL: https://svnweb.freebsd.org/changeset/ports/512052

Log:
  x11-servers/xorg-server: Packport intel PCI IDs

  Backport PCI IDs for various intel graphics cards, to enable MESA with these
  graphics cards.  According to upstream, it is safe to backport PCI IDs,
  worst case is MESA fails to initialize and fall back to software rendering,
  which would be the case without this patch anyway.

  PR:		233221
  Tested by:	Yuri Pankov

Changes:
  head/x11-servers/xorg-server/Makefile
  head/x11-servers/xorg-server/files/patch-hw_xfree86_dri2_pci__ids_i965__pci__ids.h