Bug 233260 - [PATCH] deskutils/nextcloudclient: Update to 2.5.1
Summary: [PATCH] deskutils/nextcloudclient: Update to 2.5.1
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Michael Reifenberger
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-11-16 21:31 UTC by Guido Falsi
Modified: 2018-12-09 08:12 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (mr)


Attachments
patch (4.03 KB, patch)
2018-11-16 21:31 UTC, Guido Falsi
no flags Details | Diff
Patch including upstream fix (7.55 KB, patch)
2018-11-20 16:58 UTC, Guido Falsi
no flags Details | Diff
Further upstream fix included (12.09 KB, patch)
2018-11-23 16:48 UTC, Guido Falsi
no flags Details | Diff
Update to 2.5.1 (4.48 KB, patch)
2018-12-09 08:12 UTC, Guido Falsi
madpilot: maintainer-approval? (mr)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Guido Falsi freebsd_committer 2018-11-16 21:31:04 UTC
Created attachment 199282 [details]
patch

Hi,

I've created n update to nextcloudclient to recently released 2.5.0.

Unluckily this version strictly requires OpenSSL 1.1.0. This means it can work only on 12.0 and up or 11.2 with openssl installed from ports.

Due to this I'm just proposing this patch but at present I will not commit it even in case of timeout, since I think the maintainer should choose how to deal with this.

While updating it I made a few minor changes to please portlint.

I also changed the way DEBUG is manged. It's preferred not to expose it as an option, but to conditionally enable required flags when WITH_DEBUG is enabled.

BTW there is no compatibility layer anymore between WITH_DEBUG and the DEBUG option, so to get proper debugging code (not stripped) it is required to have extra logic anyway.
Comment 1 Guido Falsi freebsd_committer 2018-11-20 16:58:54 UTC
Created attachment 199387 [details]
Patch including upstream fix

I've updated the patch to include this upstream commit:

https://github.com/nextcloud/desktop/commit/1afaa22ddbe2fe17540cd29a96e86cffd3fd73be

It stops the client from flooding the server for "activity" request if the plugin is disabled and also in some other cases.
Comment 2 Guido Falsi freebsd_committer 2018-11-23 16:48:25 UTC
Created attachment 199486 [details]
Further upstream fix included

New patch including further upstream fix for a flood/CPU hog problem.

https://github.com/nextcloud/desktop/commit/d1b9d100b420f9b4a8678a899814302025a8371e
Comment 3 Michael Reifenberger freebsd_committer 2018-12-02 11:13:32 UTC
Hi,
I'm currently trying to test the 2.5.0 version.
After upgrading my notebook to stable/12 I'm having troubles to use
this version.
Trying to conntect to https://<myserver>/ I get an error:
  Error creating SSL Context ()...
Maybe its related that on the nextcloud server I'm using self-signed Cert's
but the RootCA ind the intermediadCA certs got added to the system-wide cert
/usr/local/share/certs/ca-root-nss.crt

How did you test?

greetings
---
mike
Comment 4 Guido Falsi freebsd_committer 2018-12-02 15:22:39 UTC
I'm actually using it on my machines with my nextcloud server(which is a VM rented in the cloud). Although I have letencrypt provided certificates there.

In the past, when I was still using owncloud, I had certs created by a custom CA and I remember owncloud client asking me if I trusted the cert.

Since the client is leveraging gnome-keyring for authentication, maybe that's where it also offloads certificate verification? Otherwise I'd suspect there is a problem with functionality to accept untrusted certs.

I'm not completely sure the nextcloud desktop client checks the store in /usr/local/share/certs/ca-root-nss.crt.

BTW I'm keeping my store in /usr/local/etc/ssl/cert.pem, concatenating the ones from /usr/local/share/certs/ca-root-nss.crt and my own ones. I think that's the actual global storage, but I can't remember the details.
Comment 5 Guido Falsi freebsd_committer 2018-12-09 08:12:09 UTC
Created attachment 199969 [details]
Update to 2.5.1

Version 2.5.1 was released. It includes fixes I merged as patches.