Bug 233324 - x11/libX11: Remove unnecessary perl5 dependency
Summary: x11/libX11: Remove unnecessary perl5 dependency
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-x11 (Nobody)
Keywords: needs-qa
Depends on:
Reported: 2018-11-19 16:10 UTC by Steve Wills
Modified: 2020-06-11 18:56 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (x11)
koobs: maintainer-feedback? (zeising)

patch to remove perl dep from libX11 (496 bytes, patch)
2018-11-19 16:10 UTC, Steve Wills
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Wills freebsd_committer 2018-11-19 16:10:11 UTC
libX11 seems to have a dependency on perl5 that isn't needed. The attached patch removes the dependency and the package does not seem to change at all. I think this will need an exp-run and review by maintainer.
Comment 1 Steve Wills freebsd_committer 2018-11-19 16:10:49 UTC
Created attachment 199346 [details]
patch to remove perl dep from libX11

Somehow bugzilla failed to attach the patch. Here it is.
Comment 2 Niclas Zeising freebsd_committer 2018-11-19 18:22:29 UTC
Talking to upstream a bit, it seems like perl is used during the build somehow.  I have to look more into this.
Comment 3 Steve Wills freebsd_committer 2018-11-19 21:47:11 UTC
(In reply to Niclas Zeising from comment #2)
Configure seems to check for it, but I can't find any evidence that it uses it.
Comment 4 Mathieu Arnold freebsd_committer 2018-11-22 16:34:15 UTC
no reason for portmgr to get involved here.
Comment 5 Steve Wills freebsd_committer 2018-11-23 12:54:46 UTC
(In reply to Mathieu Arnold from comment #4)
Are you saying you think this doesn't need an exp-run? If so, great, just want to be clear.
Comment 6 Niclas Zeising freebsd_committer 2019-01-06 09:39:02 UTC
According to upstream, perl is used during the build.  I haven't investigated further exactly where.
Comment 7 Jan Beich freebsd_committer 2020-06-11 18:56:56 UTC
The code has clear references:
- specs/* but the port passes --disable-specs
- LOG_COMPILER but only used in "make check" (not "make test")

$ rg -g \*am PERL
17:endif HAVE_PERL

26:     $(AM_V_GEN)$(PERL) $(srcdir)/compose-chart.pl           \
30:     $(AM_V_GEN)$(PERL) $(srcdir)/compose-chart.pl           \

42:endif HAVE_PERL