Bug 233358 - devel/php-composer: Update to 1.8.0
Summary: devel/php-composer: Update to 1.8.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Guido Falsi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-11-20 16:50 UTC by Pedro F. Giffuni
Modified: 2018-12-13 22:09 UTC (History)
2 users (show)

See Also:
cyberbotx: maintainer-feedback+


Attachments
Update patch (980 bytes, patch)
2018-11-20 16:50 UTC, Pedro F. Giffuni
no flags Details | Diff
Update (866 bytes, patch)
2018-12-13 19:42 UTC, Guido Falsi
cyberbotx: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pedro F. Giffuni freebsd_committer 2018-11-20 16:50:04 UTC
Created attachment 199386 [details]
Update patch

Looks pretty straightforward ...
Comment 1 Naram Qashat 2018-11-20 17:06:31 UTC
Looks good to me.
Comment 2 Pedro F. Giffuni freebsd_committer 2018-12-13 19:22:55 UTC
Hmm.. 1.8.0 has been released .. will update the patch soon.
Comment 3 Guido Falsi freebsd_committer 2018-12-13 19:42:21 UTC
Created attachment 200089 [details]
Update

I discovered 1.8.0 is out and there already is this PR so I'm taking it other and proposing a further update to 1.8.0.

Thanks!
Comment 4 Guido Falsi freebsd_committer 2018-12-13 19:43:13 UTC
(In reply to Pedro F. Giffuni from comment #2)
> Hmm.. 1.8.0 has been released .. will update the patch soon.

Oops...I have seen your comment now after uploading my patch.

feel free to take the PR back!
Comment 5 Pedro F. Giffuni freebsd_committer 2018-12-13 19:56:00 UTC
(In reply to Guido Falsi from comment #4)

I am not a committer and I hadn't updated the patch yet so feel free to keep it :).
Comment 6 Naram Qashat 2018-12-13 20:09:20 UTC
Comment on attachment 200089 [details]
Update

Looks good to me.
Comment 7 commit-hook freebsd_committer 2018-12-13 22:09:16 UTC
A commit references this bug:

Author: madpilot
Date: Thu Dec 13 22:08:13 UTC 2018
New revision: 487392
URL: https://svnweb.freebsd.org/changeset/ports/487392

Log:
  Update devel/php-composer to 1.8.0

  PR:		233358
  Submitted by:	pfg, myself
  Approved by:	Naram Qashat <cyberbotx@cyberbotx.com> (maintainer)

Changes:
  head/devel/php-composer/Makefile
  head/devel/php-composer/distinfo
Comment 8 Guido Falsi freebsd_committer 2018-12-13 22:09:44 UTC
Committed. Thanks!