Bug 233439 - german/hunspell: Switch to textproc/gsed for build
Summary: german/hunspell: Switch to textproc/gsed for build
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tobias Kortkamp
URL:
Keywords:
Depends on:
Blocks: 229925
  Show dependency treegraph
 
Reported: 2018-11-23 14:46 UTC by Kyle Evans
Modified: 2019-02-26 08:41 UTC (History)
3 users (show)

See Also:


Attachments
svn(1) diff against german/hunspell (476 bytes, patch)
2018-11-23 14:46 UTC, Kyle Evans
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle Evans freebsd_committer freebsd_triage 2018-11-23 14:46:39 UTC
Created attachment 199480 [details]
svn(1) diff against german/hunspell

Hi,

hunspell's build currently attempts to use base sed and \t, most certainly with the expectation that the latter will expand to a tab. With base sed, this is currently not the case- '\t' gets passed through literally to regex(3), which sees this as an escape of an ordinary character. Escapes of ordinary characters will be disallowed in future versions of regex(3), so switch to textproc/gsed for now which does the right thing with \t anyways.

Thanks,

Kyle Evans
Comment 1 Steve Wills freebsd_committer freebsd_triage 2019-01-05 23:59:08 UTC
Assign to maintainer
Comment 2 commit-hook freebsd_committer freebsd_triage 2019-02-26 08:41:20 UTC
A commit references this bug:

Author: tobik
Date: Tue Feb 26 08:40:58 UTC 2019
New revision: 493948
URL: https://svnweb.freebsd.org/changeset/ports/493948

Log:
  german/hunspell: Use gsed during the build

  hunspell's build currently attempts to use base sed and \t, most
  certainly with the expectation that the latter will expand to a
  tab.  With base sed, this is currently not the case - '\t' gets
  passed through literally to regex(3), which sees this as an escape
  of an ordinary character.  Escapes of ordinary characters will be
  disallowed in future versions of regex(3), so switch to textproc/gsed
  for now which does the right thing with \t.

  PR:		233439
  Submitted by:	kevans
  Approved by:	office (maintainer timeout, > 2 months)

Changes:
  head/german/hunspell/Makefile