Bug 233448 - audio/fluidsynth: Update to 2.0.2
Summary: audio/fluidsynth: Update to 2.0.2
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-multimedia mailing list
URL:
Keywords:
Depends on: 233502 233462 233498 233499 233500 233501 233503
Blocks:
  Show dependency treegraph
 
Reported: 2018-11-23 19:15 UTC by Yuri Victorovich
Modified: 2019-01-05 12:30 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (multimedia)


Attachments
patch (30.71 KB, patch)
2018-11-23 19:15 UTC, Yuri Victorovich
no flags Details | Diff
patch (30.70 KB, patch)
2018-11-23 19:17 UTC, Yuri Victorovich
no flags Details | Diff
patch (30.71 KB, patch)
2018-11-23 19:18 UTC, Yuri Victorovich
no flags Details | Diff
patch (31.21 KB, patch)
2018-11-24 19:13 UTC, Yuri Victorovich
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yuri Victorovich freebsd_committer 2018-11-23 19:15:25 UTC
Upstreamed the SNDIO implementation patch that was only in the port for some reason.
Comment 1 Yuri Victorovich freebsd_committer 2018-11-23 19:15:49 UTC
Created attachment 199491 [details]
patch
Comment 2 Yuri Victorovich freebsd_committer 2018-11-23 19:17:16 UTC
Created attachment 199492 [details]
patch
Comment 3 Yuri Victorovich freebsd_committer 2018-11-23 19:18:40 UTC
Created attachment 199493 [details]
patch
Comment 4 Tobias Kortkamp freebsd_committer 2018-11-24 05:57:04 UTC
I can confirm that Sndio appears to still be functional after this
change.  audio/qsynth works fine with this update too, but please
be aware that this update breaks at least audio/lmms (see
bug #233462).  I have not tested other consumers.
Comment 5 Yuri Victorovich freebsd_committer 2018-11-24 17:41:02 UTC
(In reply to Tobias Kortkamp from comment #4)

Thank you, Tobias, for checking dependencies.


-----


There is one unexpected problem which I didn't realize existed: fluid_sndio.c has a custom license. FluidSynth needs it to be changed to LGPL in order for this code to be adopted. I contacted Jacob Meuser asking for change of license, but there is no guarantee that he will answer. If there will be no answer, we will have to keep the sndio in the port. It didn't occur to me to check the license when I submitted the patch to the FluidSynth upstream.
Comment 6 Yuri Victorovich freebsd_committer 2018-11-24 19:13:22 UTC
Created attachment 199520 [details]
patch

* Upstream the remaining FreeBSD patches
* Remove the OSS patch that doesn't seem to matter any more