Bug 233454 - mail/sendmail: remove some extraneous escaping in regex
Summary: mail/sendmail: remove some extraneous escaping in regex
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dirk Meyer
URL:
Keywords:
Depends on:
Blocks: 229925
  Show dependency treegraph
 
Reported: 2018-11-23 21:38 UTC by Kyle Evans
Modified: 2018-11-26 07:06 UTC (History)
1 user (show)

See Also:
dinoex: maintainer-feedback+


Attachments
svn(1) diff against the ports tree for libmilter and sendmail (899 bytes, patch)
2018-11-23 21:38 UTC, Kyle Evans
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle Evans freebsd_committer 2018-11-23 21:38:14 UTC
Created attachment 199499 [details]
svn(1) diff against the ports tree for libmilter and sendmail

(This patch contains the same fix for mail/libmilter as well; I've included both since you maintain both)

Hi,

sendmail and libmilter both use some extraneous escaping of ' in sed expressions. Since ' is an ordinary character in regex-land and it gets passed through as-is from make(1), this is not needed. Ordinary character escapes will be disallowed in a future version of regex(3), so we correct these now in advance of said change.

Thanks,

Kyle Evans
Comment 1 commit-hook freebsd_committer 2018-11-26 07:04:29 UTC
A commit references this bug:

Author: dinoex
Date: Mon Nov 26 07:03:48 UTC 2018
New revision: 485925
URL: https://svnweb.freebsd.org/changeset/ports/485925

Log:
  - remove some extraneous escaping in regex
  PR:		233454
  Submitted by:	Kyle Evans

Changes:
  head/mail/libmilter/Makefile
  head/mail/sendmail/Makefile
Comment 2 Dirk Meyer freebsd_committer 2018-11-26 07:06:10 UTC
looks fine.