Bug 233499 - audio/gmsynth-lv2: fails to build with fluidsynth 2.x
Summary: audio/gmsynth-lv2: fails to build with fluidsynth 2.x
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Yuri Victorovich
URL:
Keywords: needs-patch
Depends on:
Blocks: 233448
  Show dependency treegraph
 
Reported: 2018-11-25 11:57 UTC by Jan Beich
Modified: 2018-11-25 18:26 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (yuri)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer 2018-11-25 11:57:31 UTC
src/gmsynth.c:206:17: error: variable has incomplete type 'fluid_preset_t' (aka 'struct _fluid_preset_t')
        fluid_preset_t preset;
                       ^
/usr/local/include/fluidsynth/types.h:41:16: note: forward declaration of 'struct _fluid_preset_t'
typedef struct _fluid_preset_t fluid_preset_t;                  /**< SoundFont preset */
               ^
src/gmsynth.c:207:7: error: incomplete definition of type 'struct _fluid_sfont_t'
        sfont->iteration_start (sfont);
        ~~~~~^
/usr/local/include/fluidsynth/types.h:40:16: note: forward declaration of 'struct _fluid_sfont_t'
typedef struct _fluid_sfont_t fluid_sfont_t;                    /**< SoundFont */
               ^
src/gmsynth.c:209:21: error: incomplete definition of type 'struct _fluid_sfont_t'
        for (chn = 0; sfont->iteration_next (sfont, &preset); ++chn) {
                      ~~~~~^
/usr/local/include/fluidsynth/types.h:40:16: note: forward declaration of 'struct _fluid_sfont_t'
typedef struct _fluid_sfont_t fluid_sfont_t;                    /**< SoundFont */
               ^

build log: https://ptpb.pw/yOuk
Comment 1 Tobias Kortkamp freebsd_committer 2018-11-25 14:38:31 UTC
It seems a trivial update would fix it.

https://github.com/x42/gmsynth.lv2/commit/2150e139ff9fa61193be27506ad3e497fdefa76f
Comment 2 Yuri Victorovich freebsd_committer 2018-11-25 18:10:35 UTC
Remove the FluidSynth dependency.
Comment 3 commit-hook freebsd_committer 2018-11-25 18:11:02 UTC
A commit references this bug:

Author: yuri
Date: Sun Nov 25 18:10:15 UTC 2018
New revision: 485886
URL: https://svnweb.freebsd.org/changeset/ports/485886

Log:
  audio/gmsynth-lv2: Update 0.3.0 -> 0.3.0-5

  Change back to bundled FluidSynth based on the project owner's request.

  PR:		233499

Changes:
  head/audio/gmsynth-lv2/Makefile
  head/audio/gmsynth-lv2/distinfo
  head/audio/gmsynth-lv2/files/