Bug 233500 - audio/fluidplug-lv2: fails to build with fluidsynth 2.x
Summary: audio/fluidplug-lv2: fails to build with fluidsynth 2.x
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Yuri Victorovich
URL: https://github.com/falkTX/FluidPlug/i...
Keywords: needs-patch
Depends on:
Blocks: 233448
  Show dependency treegraph
 
Reported: 2018-11-25 11:57 UTC by Jan Beich
Modified: 2018-12-08 17:16 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (yuri)


Attachments
fluidplug-lv2-fluidsynth2.diff (2.01 KB, patch)
2018-12-08 10:53 UTC, Tobias Kortkamp
tobik: maintainer-approval? (yuri)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer 2018-11-25 11:57:33 UTC
source/FluidPlug.c:133:20: error: variable has incomplete type 'fluid_preset_t' (aka 'struct _fluid_preset_t')
    fluid_preset_t preset;
                   ^
/usr/local/include/fluidsynth/types.h:41:16: note: forward declaration of 'struct _fluid_preset_t'
typedef struct _fluid_preset_t fluid_preset_t;                  /**< SoundFont preset */
               ^
source/FluidPlug.c:135:10: error: incomplete definition of type 'struct _fluid_sfont_t'
    sfont->iteration_start(sfont);
    ~~~~~^
/usr/local/include/fluidsynth/types.h:40:16: note: forward declaration of 'struct _fluid_sfont_t'
typedef struct _fluid_sfont_t fluid_sfont_t;                    /**< SoundFont */
               ^
source/FluidPlug.c:136:26: error: incomplete definition of type 'struct _fluid_sfont_t'
    for (count = 0; sfont->iteration_next(sfont, &preset) != 0;)
                    ~~~~~^
/usr/local/include/fluidsynth/types.h:40:16: note: forward declaration of 'struct _fluid_sfont_t'
typedef struct _fluid_sfont_t fluid_sfont_t;                    /**< SoundFont */
               ^
source/FluidPlug.c:147:10: error: incomplete definition of type 'struct _fluid_sfont_t'
    sfont->iteration_start(sfont);
    ~~~~~^
/usr/local/include/fluidsynth/types.h:40:16: note: forward declaration of 'struct _fluid_sfont_t'
typedef struct _fluid_sfont_t fluid_sfont_t;                    /**< SoundFont */
               ^
source/FluidPlug.c:148:26: error: incomplete definition of type 'struct _fluid_sfont_t'
    for (count = 0; sfont->iteration_next(sfont, &preset) != 0;)
                    ~~~~~^
/usr/local/include/fluidsynth/types.h:40:16: note: forward declaration of 'struct _fluid_sfont_t'
typedef struct _fluid_sfont_t fluid_sfont_t;                    /**< SoundFont */
               ^

build log: https://ptpb.pw/Un0z
Comment 1 Tobias Kortkamp freebsd_committer 2018-12-08 10:53:21 UTC
Created attachment 199952 [details]
fluidplug-lv2-fluidsynth2.diff

Hi Yuri,

this patch fixes the build with FluidSynth 2.x.  Can you check if it works
at runtime too?

If this works for you, I'll open a PR for this upstream.

Thanks.
Comment 2 Tobias Kortkamp freebsd_committer 2018-12-08 11:13:36 UTC
(In reply to Tobias Kortkamp from comment #1)
Pull Request: https://github.com/falkTX/FluidPlug/pull/7
Comment 3 Yuri Victorovich freebsd_committer 2018-12-08 17:16:28 UTC
Committed as PATCHxx statements.
Comment 4 commit-hook freebsd_committer 2018-12-08 17:16:49 UTC
A commit references this bug:

Author: yuri
Date: Sat Dec  8 17:16:23 UTC 2018
New revision: 486965
URL: https://svnweb.freebsd.org/changeset/ports/486965

Log:
  audio/fluidplug-lv2: Fix build with fluidsynth 2.x

  Add PATCHxx statements for https://github.com/falkTX/FluidPlug/pull/7.

  PR:		233500
  Submitted by:	tobik
  Reported by:	jbeich

Changes:
  head/audio/fluidplug-lv2/Makefile
  head/audio/fluidplug-lv2/distinfo