Bug 233549 - math/reduce: Looks for gnuplot in a wrong location
Summary: math/reduce: Looks for gnuplot in a wrong location
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Pedro F. Giffuni
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-11-26 22:28 UTC by Yuri Victorovich
Modified: 2019-08-15 16:00 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (pfg)


Attachments
Update math/reduce to version 20181123 (1.26 KB, patch)
2018-11-27 00:54 UTC, Pedro F. Giffuni
no flags Details | Diff
Update math/reduce to version 20181123 (2.25 KB, patch)
2018-11-27 01:09 UTC, Pedro F. Giffuni
no flags Details | Diff
Update math/reduce to version 20181123 (2.77 KB, patch)
2018-11-27 05:50 UTC, Pedro F. Giffuni
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yuri Victorovich freebsd_committer 2018-11-26 22:28:29 UTC
The GNUPLOT module fails because it looks for the 'gnuplot' executable in /usr/local/share/gnuplot.

Version 20180117_2
Comment 1 Pedro F. Giffuni freebsd_committer 2018-11-27 00:54:49 UTC
Created attachment 199587 [details]
Update math/reduce to version 20181123
Comment 2 Pedro F. Giffuni freebsd_committer 2018-11-27 01:09:12 UTC
Created attachment 199588 [details]
Update math/reduce to version 20181123

New update: attempt to fix gnuplot by having it detected early.
Comment 3 Pedro F. Giffuni freebsd_committer 2018-11-27 01:14:00 UTC
(In reply to Yuri Victorovich from comment #0)

TBH, I am not sure of the fix:some while ago it seemed like gnuplot was not referred to in the build log so I moved it to a run dependency but didn't test it. FWIW, the windows port carries a binary version.

According to the mailing lists, upstream recommends installing gnuplot before reduce so the (attached) updated port adds a build dependency as well.

Hope that helps.
Comment 4 Pedro F. Giffuni freebsd_committer 2018-11-27 05:50:46 UTC
Created attachment 199593 [details]
Update math/reduce to version 20181123

Minor cosmetic fixes in a failed attempt to make portlint happy.
Comment 5 Pedro F. Giffuni freebsd_committer 2019-01-08 18:43:32 UTC
Comment on attachment 199593 [details]
Update math/reduce to version 20181123

Drop the patch: its only slightly related and I don't have areal fix yet.
Comment 6 Pedro F. Giffuni freebsd_committer 2019-01-08 18:46:38 UTC
The port update is now on a different PR.
Comment 7 Pedro F. Giffuni freebsd_committer 2019-01-09 18:35:10 UTC
Rainer Rainer Schöpf kindly gave me some pointers concerning gnuplot executables:

The current logic for PSL Reduce is 
   (1) if $GNUPLOT is set, run $GNUPLOT/gnuplot
   (2) otherwise, run gnuplot (relying on $PATH)

For CSL Reduce, it is slightly more complicated
 (1) If an environment variable GNUPLOT is set then that should be set to
     a path within which the gnuplot executable exists. So eg if the
     value of GNUPLOT is "/usr/extras/gnuplotfiles" then the result
     here is liable to be "/usr/extras/gnuplotfiles/gnuplot".
 (2) If a file called "gnuplot" (or "wgnuplot.exe in the windows case) is
     present in the directory where the Reduce executable was found then
     it will be used.
 (3) If a file called "gnuplot" (or "wgnuplot.exe in the windows case) is
     present in the directory where the Reduce image would (by default)
     be found then it will be used.  In some cases this is actually the
     same as (2) above, but it can differ if the executable is in
     .../bin and the image in .../share/reduce or some such.
 (4) A search will be made in the "standard place". For Windows this will
     involve scanning the registry to seek an installation of gnuplot,
     while otherwise it will be expected that the ordinary PATH will
     provide access.
 (5) Failing all else I will just hand back the name of the executable and
     hope that it is on a PATH.
Comment 8 Walter Schwarzenfeld freebsd_triage 2019-08-15 13:57:43 UTC
We have version 20190413. Is this still relevant?
Comment 9 Pedro F. Giffuni freebsd_committer 2019-08-15 15:15:49 UTC
(In reply to Walter Schwarzenfeld from comment #8)

It depends on Yuri (no feedback) but I did what I could.
Comment 10 Yuri Victorovich freebsd_committer 2019-08-15 16:00:29 UTC
(In reply to Pedro F. Giffuni from comment #9)

Sorry, I can't retest it now.