Bug 233562 - ipfw: limit for IPv4 keepalive queue is reached
Summary: ipfw: limit for IPv4 keepalive queue is reached
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: 11.2-RELEASE
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ipfw (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-11-27 12:45 UTC by Compri
Modified: 2019-06-13 01:37 UTC (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Compri 2018-11-27 12:45:49 UTC 
I have many messages: ipfw: IPv4 keepvive limit has been reached

What can be the cause?
Comment 1 commit-hook freebsd_committer freebsd_triage 2018-11-27 16:52:03 UTC 
A commit references this bug:

Author: ae
Date: Tue Nov 27 16:51:01 UTC 2018
New revision: 341073
URL: https://svnweb.freebsd.org/changeset/base/341073

Log:
  Do not limit the mbuf queue length for keepalive packets.

  It was unlimited before overhaul, and one user reported that this limit
  can be reached easily.

  PR:		233562
  MFC after:	1 week

Changes:
  head/sys/netpfil/ipfw/ip_fw_dynamic.c
Comment 2 Compri 2018-11-28 08:17:54 UTC 
Thanks for the answer. I re-edited my sysctl.conf and changed the buffer. I think it's Ok now.
Comment 3 Andrey V. Elsukov freebsd_committer freebsd_triage 2018-11-28 08:29:12 UTC 
(In reply to Compri from comment #2)
> Thanks for the answer. I re-edited my sysctl.conf and changed the buffer. I
> think it's Ok now.

No, it can not be changed via sysctl.conf, you need to modify the source code using the patch from commit message and recompile the ipfw module.
Comment 4 commit-hook freebsd_committer freebsd_triage 2018-12-04 09:16:29 UTC 
A commit references this bug:

Author: ae
Date: Tue Dec  4 09:16:20 UTC 2018
New revision: 341461
URL: https://svnweb.freebsd.org/changeset/base/341461

Log:
  MFC r341073:
    Do not limit the mbuf queue length for keepalive packets.

    It was unlimited before overhaul, and one user reported that this limit
    can be reached easily.

    PR:		233562

Changes:
_U  stable/12/
  stable/12/sys/netpfil/ipfw/ip_fw_dynamic.c
Comment 5 commit-hook freebsd_committer freebsd_triage 2018-12-04 09:18:34 UTC 
A commit references this bug:

Author: ae
Date: Tue Dec  4 09:18:29 UTC 2018
New revision: 341462
URL: https://svnweb.freebsd.org/changeset/base/341462

Log:
  MFC r341073:
    Do not limit the mbuf queue length for keepalive packets.

    It was unlimited before overhaul, and one user reported that this limit
    can be reached easily.

    PR:		233562

Changes:
_U  stable/11/
  stable/11/sys/netpfil/ipfw/ip_fw_dynamic.c
Comment 6 Scott Aitken 2019-05-29 02:00:58 UTC 
Hi,

I'm running 12.0-RELEASE FreeBSD 12.0-RELEASE r341666 GENERIC  amd64. Is is ok to compile this version of ip_fw_dynamic.c?

Thanks
Comment 7 Andrey V. Elsukov freebsd_committer freebsd_triage 2019-05-29 07:28:03 UTC 
(In reply to Scott Aitken from comment #6)
> Hi,
> 
> I'm running 12.0-RELEASE FreeBSD 12.0-RELEASE r341666 GENERIC  amd64. Is is
> ok to compile this version of ip_fw_dynamic.c?

Hi,

you need to apply the patch or use stable/12 branch.
Comment 8 Scott Aitken 2019-05-29 07:29:55 UTC 
Great.  Thanks for that.  I'm on RELEASE so I'll just recompile IPFW.

Scott
Comment 9 Christos Chatzaras 2019-06-13 01:37:52 UTC 
This patch is included only in 12-STABLE and not 12.0, right?