Bug 233570 - www/nginx: Update modsecurity 3 plugin
Summary: www/nginx: Update modsecurity 3 plugin
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jochen Neumeister
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-11-27 16:11 UTC by Marius Halden
Modified: 2018-12-14 11:10 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (joneum)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marius Halden 2018-11-27 16:11:48 UTC 
The linked patch on phabricator updates the modsecurity 3 plugin to a version which includes the modsecurity_transaction_id statement. More details can be found in the phabricator thread.
cf https://reviews.freebsd.org/D18358
Comment 1 Jochen Neumeister freebsd_committer freebsd_triage 2018-11-27 16:20:04 UTC 
Aloah :-)

Thank you for the PR. It's enough if you open a PR and make a diff here. Review is more for mentor/mentee persons.

Bump PORTREVISION is not necessary here, because I get Modsecurity3 directly from Github via GH_TUPLE. I use here not the releases, rather the commits directly
Comment 2 Jochen Neumeister freebsd_committer freebsd_triage 2018-11-27 16:24:04 UTC 
Aloha,
my mistake, i assumed you want a bump from PORTREVISON because of update modsecurity to 3.0.3.
I will commit this update, VTS and other 3rd party modules all the days.
Comment 3 Marius Halden 2018-11-27 16:31:59 UTC 
I was a bit confused for a second about the portrevision now, but no worriees :)

For using phabricator, I was told to use it for the VTS patch and the modsecurity v3.0.3 patch so I assumed it would be OK for this one too. To be honest I found the experience to be preferable compared to just posting a patch here.

Thanks for helping get this in.
Comment 4 Jochen Neumeister freebsd_committer freebsd_triage 2018-12-14 11:10:08 UTC 
Landed in r487421 with a other Versionsnumber. Thx :)