Bug 233591 - mail/thunderbird has incorrect icon name in desktop file
Summary: mail/thunderbird has incorrect icon name in desktop file
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-gecko mailing list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-11-27 23:46 UTC by Zach Dykstra
Modified: 2018-11-28 00:10 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (gecko)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Zach Dykstra 2018-11-27 23:46:06 UTC
The thunderbird.desktop file has an incorrectly defined Icon entry. Icon entries with out an explicit full path to the icon should be set with out a file suffix.

Icon=thunderbird.png

This should instead be:

Icon=thunderbird

With it set to thunderbird.png, launchers and other .desktop consumers are looking for thunderbird.png.{png,xpm,svg}, which will fail. Removing the extension allows 'rofi' to correctly show an icon for Thunderbird in the launcher.
Comment 1 Zach Dykstra 2018-11-28 00:10:12 UTC
--- Makefile    2018-11-27 18:09:01.939635000 -0600
+++ Makefile.no-suffix  2018-11-27 18:08:39.801660000 -0600
@@ -58,7 +58,7 @@
 .endif
 
 post-extract:
-       @${SED} -e 's|@PORTNAME_ICON@|${PORTNAME_ICON}|;s|@MOZILLA@|${MOZILLA}|' \
+       @${SED} -e 's|@PORTNAME_ICON@|${PORTNAME_ICON:R}|;s|@MOZILLA@|${MOZILLA}|' \
                <${FILESDIR}/thunderbird.desktop.in >${WRKDIR}/${MOZILLA_EXEC_NAME}.desktop
 
 post-patch:

The above diff seems to generate the correct work/thunderbird.desktop file.