Bug 233671 - graphics/opencolorio: fix build with GCC-based architectures
Summary: graphics/opencolorio: fix build with GCC-based architectures
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Mark Linimon
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-11-30 19:09 UTC by Piotr Kubaj
Modified: 2018-12-09 15:20 UTC (History)
2 users (show)

See Also:
FreeBSD: maintainer-feedback+


Attachments
patch (460 bytes, patch)
2018-11-30 19:09 UTC, Piotr Kubaj
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj 2018-11-30 19:09:07 UTC
Created attachment 199692 [details]
patch

Since the port links to libraries compiled with GCC7 on GCC architectures, add USES=compiler:c++11-lang to fix linking.

Tested on powerpc64 and amd64.

Hardware sponsored by IntegriCloud.
Comment 1 commit-hook freebsd_committer 2018-12-02 03:09:31 UTC
A commit references this bug:

Author: linimon
Date: Sun Dec  2 03:09:03 UTC 2018
New revision: 486394
URL: https://svnweb.freebsd.org/changeset/ports/486394

Log:
  Since this port links to libraries compiled with GCC7 on GCC-based
  architectures, add USES=compiler:c++11-lang to fix linking.

  PR:		233671
  Submitted by:	Piotr Kubaj
  Approved by:	portmgr (tier-2 blanket)

Changes:
  head/graphics/opencolorio/Makefile
Comment 2 Shane 2018-12-05 09:03:14 UTC
I don't see any issues with this. I have updated the patch in bug #225941 to match.

Other ports that I maintain also have USES=compiler with C++11 or C++14 which were put in place to fix builds on 10.4 due to the base clang failing. Most of these ports use opencolorio - openimageio openshadinglanguage blender

I was planning to remove these with next updates now that 10.4 is EOL, should these be kept in place to support GCC archs? See based on failed builds?

devel/godot and godot2 also have USES=compiler for the same reason but these are more standalone so expect these can be removed.
Comment 3 Piotr Kubaj 2018-12-05 12:48:13 UTC
(In reply to Shane from comment #2)
Yes, those should be left, because of base GCC.

Base GCC doesn't even support C++03, let alone C++11 and newer.

It also doesn't support C11.

Please leave it as it is, unless those ports compile with GCC 4.2.
Comment 4 Mark Linimon freebsd_committer freebsd_triage 2018-12-09 15:20:00 UTC
Now see PR 233888.