Bug 233728 - www/miniflux: Update to 2.0.13
Summary: www/miniflux: Update to 2.0.13
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kirill Ponomarev
Keywords: needs-qa
Depends on:
Reported: 2018-12-02 19:20 UTC by Frédéric Guillot
Modified: 2018-12-09 09:25 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (krion)

patch (3.83 KB, patch)
2018-12-02 19:20 UTC, Frédéric Guillot
no flags Details | Diff
supports all architectures (3.70 KB, patch)
2018-12-02 21:36 UTC, Frédéric Guillot
no flags Details | Diff
patch without git (2.83 KB, patch)
2018-12-06 05:18 UTC, Frédéric Guillot
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Frédéric Guillot 2018-12-02 19:20:38 UTC
Created attachment 199761 [details]

- Update Miniflux to the latest stable version
- Update Makefile to use go modules
- Use correct URL
- Add man page
Comment 1 Nathan 2018-12-02 19:49:16 UTC
Comment on attachment 199761 [details]

Why is it now marked only for amd64?
Comment 2 Frédéric Guillot 2018-12-02 19:56:30 UTC
(In reply to Nathan from comment #1)

The Miniflux's Makefile is using only GOARCH=amd64: https://github.com/miniflux/miniflux/blob/2.0.13/Makefile#L36
Comment 3 Nathan 2018-12-02 19:58:06 UTC
Maybe try using REINPLACE_CMD -e '/^freebsd/s|amd64|${ARCH}|'
Comment 4 Frédéric Guillot 2018-12-02 21:36:37 UTC
Created attachment 199766 [details]
supports all architectures
Comment 5 Frédéric Guillot 2018-12-02 21:39:36 UTC
I uploaded a new attachment that patches Miniflux's Makefile.

It won't be necessary for the next version as I made the changes upstream.
Comment 6 Kirill Ponomarev freebsd_committer 2018-12-04 16:05:19 UTC
Frankly, I absolutely hate an idea to use git as a dependency. Could you fix it in upstream and provide full sources in your tarball?
Comment 7 Frédéric Guillot 2018-12-05 01:14:50 UTC
(In reply to Kirill Ponomarev from comment #6)
Git is required by Go modules.
Comment 8 Frédéric Guillot 2018-12-05 01:15:31 UTC
(In reply to Kirill Ponomarev from comment #6)
The full source are already in the tarball.
Comment 9 Kirill Ponomarev freebsd_committer 2018-12-05 15:03:24 UTC
(In reply to Frédéric Guillot from comment #7)
Yes, and that's what I really don't like.
Comment 10 Frédéric Guillot 2018-12-06 05:18:36 UTC
Created attachment 199880 [details]
patch without git

Try this one. There is not git.

Postgres doesn't need to be a dependency, you can install postgres on a separate server...
Comment 11 commit-hook freebsd_committer 2018-12-06 17:51:27 UTC
A commit references this bug:

Author: krion
Date: Thu Dec  6 17:50:56 UTC 2018
New revision: 486772
URL: https://svnweb.freebsd.org/changeset/ports/486772

  Update to 2.0.13

  PR:		233728
  Submitted by:	Fr?d?ric Guillot <fred@miniflux.net>