Bug 233772 - cad/z88: Update to v15
Summary: cad/z88: Update to v15
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs mailing list
URL:
Keywords: needs-patch
Depends on:
Blocks:
 
Reported: 2018-12-04 11:52 UTC by kunda
Modified: 2018-12-06 23:19 UTC (History)
2 users (show)

See Also:


Attachments
z88 update to 15 patch (34.19 KB, patch)
2018-12-06 23:19 UTC, Lorenzo Salvadore
phascolarctos: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description kunda 2018-12-04 11:52:26 UTC
z88os v15 released 17.07.2017 https://forum.z88.de/viewtopic.php?f=18&t=885
Comment 1 Lorenzo Salvadore 2018-12-05 10:30:40 UTC
I will try to update the port.
Comment 2 Lorenzo Salvadore 2018-12-06 23:19:00 UTC
Created attachment 199912 [details]
z88 update to 15 patch

Here is the patch for z88. I did not find a changelog for the software.

Here is a summary of the changes made to the port.

- Changes PORTVERSION to DISTVERSION. I have checked that PORTVERSION keeps increasing.
- Sets myself as MAINTAINER.
- Uses USE_GITHUB instead of MASTER_SITES (I find it easier to maintain).
- Sets LICENSE.
- Sets appropriate dependencies, USES, USE_X.
- Adds an EXAMPLES option.
- Adds a pkg-message to explain how the port must be used, as it is not self-evident (The software assumes all files in the same directory instead of distributed into bin/, ${DATADIR} etc so I had to find a work around: the solution is easy for the user).

Portlint remarks that some of my patches contains ^M characters and suggests the use of USE+=dos2unix. I refrained to do that because this concerns only some files in the working directory while installed files should be clean, so I thought it was better to keep the port simple.

Tested successfully with poudriere (11.2-RELEASE-p6 i386/amd64).