Bug 233781 - devel/py-freebsd: Update to 0.9.4, Fix with python 3.x support
Summary: devel/py-freebsd: Update to 0.9.4, Fix with python 3.x support
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-python mailing list
URL:
Keywords: needs-patch, needs-qa
: 233782 (view as bug list)
Depends on:
Blocks:
 
Reported: 2018-12-04 16:34 UTC by Maxim Sobolev
Modified: 2018-12-05 03:25 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (python)
koobs: maintainer-feedback? (sobomax)


Attachments
Patch to update the port (8.78 KB, patch)
2018-12-04 16:34 UTC, Maxim Sobolev
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Maxim Sobolev freebsd_committer 2018-12-04 16:34:07 UTC
Created attachment 199819 [details]
Patch to update the port

This patch updates devel/py-freebsd to the latest version as well as enables python 3.x support in its builds.
Comment 1 Maxim Sobolev freebsd_committer 2018-12-04 16:43:32 UTC
*** Bug 233782 has been marked as a duplicate of this bug. ***
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2018-12-05 03:25:47 UTC
Thank you Maxim. A couple of review items:

1) GH_TAGNAME=	v${PORTVERSION} - Use DISTVERSIONPREFIX=v, drop GH_TAGNAME

2) Can you provide detail or explanation (and include in the commit message after approval) of:

a) the upstream change. Is it a fork, did you transfer/coordinate with perky to move it to GitHub?
b) The patch removals. Were they upstreamed? No longer necessary?

3) Since it appears the upstream is not hosted under your GitHub account, would you like to update MAINTAINER to yourself? Please include that change if so.

4) The package includes tests. Can you add TEST_DEPENDS (if necessary) and a test target to run them. Ideally this should be integrated upstream, using setup.py test (setup.py:tests_require,test_suite, et al)

5) Was Python 3 support supposed to work prior to this, but was broken? Or was Python 3 support recently added upstream and in this version? If the latter, update the issue summary (and commit log message) to say 'Enable Python3.x support' rather than 'Fix Python 3.x support'

Longer term (not for this commit), can we look at distributing/publishing this to PyPI (CHEESESHOP). In particular, it would be good to have a 'registered' and canonical name for this package. Right now the portname is 'freebsd', but the actual upstream / distname is 'py-freebsd'. I'd go with just 'freebsd' for PyPI, to match the current PORTNAME. It doesn't ultimate matter what the repo name is.