Bug 233809 - science/lamprop: Update to 3.8
Summary: science/lamprop: Update to 3.8
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Wen Heping
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-12-05 19:47 UTC by rsmith
Modified: 2018-12-20 12:31 UTC (History)
2 users (show)

See Also:

Attachments
patch (2.21 KB, patch)
2018-12-05 19:47 UTC, rsmith 		no flags Details | Diff
test report by script(1) (3.89 KB, text/plain)
2018-12-05 19:49 UTC, rsmith 		no flags Details
Updated patch for the port. (2.19 KB, patch)
2018-12-06 06:45 UTC, rsmith 		koobs: maintainer-approval+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description rsmith 2018-12-05 19:47:13 UTC 
Created attachment 199859 [details]
patch

Update lamprop to 3.8.

Patch for port directory attached.

The updated port was tested according to the handbook. No problems were found.
Comment 1 rsmith 2018-12-05 19:49:38 UTC 
Created attachment 199860 [details]
test report by script(1)
Comment 2 Nathan 2018-12-05 23:45:28 UTC 
Comment on attachment 199859 [details]
patch

Leave NO_ARCH where it was, except put a space between GH_ACCOUNT and NO_ARCH
Comment 3 rsmith 2018-12-06 06:45:04 UTC 
Created attachment 199882 [details]
Updated patch for the port.
Comment 4 rsmith 2018-12-06 06:47:34 UTC 
(In reply to Nathan from comment #2)

Done, see updated patch. Portlint is now silent.
Comment 5 Nathan 2018-12-06 06:48:26 UTC 
(In reply to rsmith from comment #4)
Looks better, here is a reference for variable order:
https://www.freebsd.org/doc/en/books/porters-handbook/porting-order.html
Comment 6 commit-hook freebsd_committer 2018-12-19 11:43:09 UTC 
A commit references this bug:

Author: wen
Date: Wed Dec 19 11:42:06 UTC 2018
New revision: 487795
URL: https://svnweb.freebsd.org/changeset/ports/487795

Log:
  - Update to 3.8

  PR:		233809
  Submitted by:	rsmith@xs4all.nl(maintainer)

Changes:
  head/science/lamprop/Makefile
  head/science/lamprop/distinfo
  head/science/lamprop/files/