Bug 233822 - [NEW PORT] security/py-python-axolotl-curve25519: Python wrapper for curve25519 with ed25519 signatures
Summary: [NEW PORT] security/py-python-axolotl-curve25519: Python wrapper for curve255...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Ruslan Makhmatkhanov
Keywords: feature, needs-patch, needs-qa
Depends on:
Blocks: 233823
  Show dependency treegraph
Reported: 2018-12-06 11:42 UTC by Goran Mekić
Modified: 2019-01-26 10:57 UTC (History)
3 users (show)

See Also:
koobs: maintainer-feedback? (meka)

py-axolotl-curve25519.shar (1.70 KB, text/plain)
2018-12-06 11:42 UTC, Goran Mekić
no flags Details
py-axolotl-curve25519.shar (1.81 KB, text/plain)
2019-01-05 04:59 UTC, Goran Mekić
no flags Details
py-python-axolotl-curve25519.shar (1.71 KB, text/plain)
2019-01-05 17:15 UTC, Goran Mekić
meka: maintainer-approval+
py-python-axolotl-curve25519.shar (1.79 KB, text/plain)
2019-01-05 17:19 UTC, Goran Mekić
meka: maintainer-approval+
py-python-axolotl-curve25519-stagedr.shar (1.80 KB, text/plain)
2019-01-05 17:56 UTC, Goran Mekić
meka: maintainer-approval+

Note You need to log in before you can comment on or make changes to this bug.
Description Goran Mekić 2018-12-06 11:42:36 UTC
Created attachment 199886 [details]
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2018-12-07 05:29:52 UTC
Thank you for submitting a new FreeBSD ports Goran. A couple of review items:

Upstream/canonical name is 'python-axolotl-curve25519' [1], please rename.

Appears to install a C extension that should be stripped at post-install

[1] https://pypi.org/project/python-axolotl-curve25519/
Comment 2 Goran Mekić 2019-01-05 04:59:40 UTC
Created attachment 200783 [details]

Thanx for the tips!
Comment 3 Kubilay Kocak freebsd_committer freebsd_triage 2019-01-05 10:05:34 UTC
(In reply to Goran Mekić from comment #2)

The directory still needs to be renamed py-python-axolotl-curve25519. Could you regenerate the shell archive (or alternatively use an svn or unified diff)

Also for the STRIP_CMD, you can use PYTHONPREFIX_SITELIBDIR instead of "${PREFIX}/lib/python${PYTHON_VER}"

And STAGE should be STAGEDIR

Ideally this port should be run through QA and confirmed to pass, at least portlint and poudriere [1]

[1] https://www.freebsd.org/doc/en/books/porters-handbook/testing.html
Comment 4 Goran Mekić 2019-01-05 17:15:15 UTC
Created attachment 200803 [details]

Thank you for the patience and guidance, I'm really grateful! Portlint and "poudriere testport" say it's OK, installing it and using it via gajim+OMEMO works.
Comment 5 Goran Mekić 2019-01-05 17:19:44 UTC
Created attachment 200804 [details]

Bad shar, sorry! I generated new one.
Comment 6 Goran Mekić 2019-01-05 17:56:05 UTC
Created attachment 200806 [details]

Comment 7 commit-hook freebsd_committer 2019-01-26 10:52:53 UTC
A commit references this bug:

Author: rm
Date: Sat Jan 26 10:52:12 UTC 2019
New revision: 491261
URL: https://svnweb.freebsd.org/changeset/ports/491261

  Python wrapper for curve25519 library with ed25519 signatures.

  WWW: https://github.com/tgalal/python-axolotl-curve25519

  PR:		233822
  Submitted by:	meka@tilda.center

Comment 8 Ruslan Makhmatkhanov freebsd_committer 2019-01-26 10:57:26 UTC
New port added. Thank you!
Comment 9 Ruslan Makhmatkhanov freebsd_committer 2019-01-26 10:57:47 UTC
Assign to me