Bug 233894 - Improve the handbook section about leaf/automatic packages
Summary: Improve the handbook section about leaf/automatic packages
Status: Closed FIXED
Alias: None
Product: Documentation
Classification: Unclassified
Component: Books & Articles (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Guangyuan Yang
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-12-09 17:47 UTC by Erwan Martin
Modified: 2018-12-22 09:14 UTC (History)
2 users (show)

See Also:


Attachments
Patch (2.52 KB, patch)
2018-12-09 17:47 UTC, Erwan Martin
no flags Details | Diff
Patch (v2), validated by igor (2.53 KB, patch)
2018-12-09 18:03 UTC, Erwan Martin
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Erwan Martin 2018-12-09 17:47:42 UTC
Created attachment 199986 [details]
Patch

This is a patch to improve the handbook section about leaf/automatic packages.

It includes how to list the prime (non automatic) packages, and how to mark a package as automatic or as non automatic.
Comment 1 Erwan Martin 2018-12-09 18:03:47 UTC
Created attachment 199987 [details]
Patch (v2), validated by igor
Comment 2 Erwan Martin 2018-12-09 18:05:00 UTC
I forgot to process the patch using `igor` when I created the patch.
I added the corrected version as a second patch. Please disregard the first file.
Comment 3 Guangyuan Yang freebsd_committer freebsd_triage 2018-12-10 05:30:27 UTC
Hi, thanks for the patch! Please submit this to https://reviews.freebsd.org/ so it can be better reviewed.
Comment 4 Erwan Martin 2018-12-10 10:56:46 UTC
(In reply to Guangyuan Yang from comment #3)

Done:

https://reviews.freebsd.org/D18497

I hope I did it right. Let me know if I missed something.

Anyway; is this the normal procedure?
If it is, I think we should also update the fdp-primer section of the documentation (https://www.freebsd.org/doc/en_US.ISO8859-1/books/fdp-primer/overview.html#overview-quick-start)
Comment 5 commit-hook freebsd_committer freebsd_triage 2018-12-21 18:16:52 UTC
A commit references this bug:

Author: bcr
Date: Fri Dec 21 18:16:06 UTC 2018
New revision: 52705
URL: https://svnweb.freebsd.org/changeset/doc/52705

Log:
  Improve the handbook section about leaf/automatic packages.

  The patch includes instructions on how to list the prime (non-automatic)
  packages, and how to mark a package as automatic or non-automatic.

  PR:			233894
  Submitted by:		public@fzwte.net
  Reviewed by:		ygy@, myself
  Approved by:		ygy
  Differential Revision:	https://reviews.freebsd.org/D18497

Changes:
  head/en_US.ISO8859-1/books/handbook/ports/chapter.xml
Comment 6 Benedict Reuschling freebsd_committer freebsd_triage 2018-12-21 18:18:23 UTC
Patch was committed just now. Thanks for submitting it!
@ygy: Hope it's OK that I committed it and am closing this PR.
Comment 7 Guangyuan Yang freebsd_committer freebsd_triage 2018-12-22 09:14:02 UTC
(In reply to Benedict Reuschling from comment #6)

Thanks for committing this! I am hoping to encourage people to use Phabricator for doc patches - maybe there's a better way to cross-reference those to Bugzilla in the future.