Bug 233957 - [NEW PORT] emulators/fs-uae-devel: Amiga emulator (development branch)
Summary: [NEW PORT] emulators/fs-uae-devel: Amiga emulator (development branch)
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Johannes Lundberg
URL: https://reviews.freebsd.org/D20064
Keywords: feature, needs-qa
Depends on: 233956
Blocks:
  Show dependency treegraph
 
Reported: 2018-12-12 13:06 UTC by Johannes Lundberg
Modified: 2019-06-01 02:54 UTC (History)
4 users (show)

See Also:
koobs: maintainer-feedback? (johalun0)


Attachments
Add emulators/fs-uae-devel port (4.16 KB, patch)
2018-12-12 13:06 UTC, Johannes Lundberg
no flags Details | Diff
Add emulators/fs-uae-devel port. Updated COMMENT as suggested. (4.18 KB, patch)
2018-12-14 09:12 UTC, Johannes Lundberg
no flags Details | Diff
Make this a slave port of fs-uae (1.12 KB, patch)
2018-12-14 10:42 UTC, Johannes Lundberg
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Johannes Lundberg 2018-12-12 13:06:08 UTC
Created attachment 200055 [details]
Add emulators/fs-uae-devel port

Add fs-uae-devel port that fetches most recent code from Github.
Use GCC as compiler since it gives better Amiga performance.
Conflicts with fs-uae.

Built in poudriere for amd64 13-CURRENT.
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2018-12-14 05:43:20 UTC
Thank you for your contribution Johannes.

Can you please update COMMENT to be the same as the fs-uae port, with "(development branch)" appended please
Comment 2 Johannes Lundberg 2018-12-14 09:12:02 UTC
Created attachment 200107 [details]
Add emulators/fs-uae-devel port. Updated COMMENT as suggested.
Comment 3 Kubilay Kocak freebsd_committer freebsd_triage 2018-12-14 09:32:27 UTC
I missed this (in hindsight obvious issue) on initial cursory review, but since the vast majority of this port shares its contents with emulators/fs-uae, this should be a sub (slave) port of it, overriding the relevant bits: PORTVERSION, MASTER_SITES, COMMENT, MAINTAINER, etc. 

Note: The relevant directives in the primary (master) port should have their assignment operators changed to ?= to allow overriding them elsewhere.

Also, the +USE_GCC=any [1] should be removed from the emulators/fs-uae diff section, as it is unrelated, and part of a proposal in a separate issue, but nice work adding the CONFLICTS there!

[1] See Also: bug 233956
Comment 4 Johannes Lundberg 2018-12-14 10:42:38 UTC
Created attachment 200112 [details]
Make this a slave port of fs-uae
Comment 5 Johannes Lundberg freebsd_committer 2019-05-21 21:35:48 UTC
Review here https://reviews.freebsd.org/D20064
Comment 6 Kubilay Kocak freebsd_committer freebsd_triage 2019-06-01 02:54:16 UTC
Reporter is committer, assign accordingly

@Johannes Should we merge your Bugzilla accounts? Please open an issue under Services::Bug Tracker to do so, and ack/comment from each account. You may also want to update any ports MAINTAINER lines to your @FreeBSD.org address, so that the Bugzilla autoassigner can work correctly, and maintainership/approval can be verified