Bug 233969 - Improve performance of Dell Intel P4600 NVMe SSDs
Summary: Improve performance of Dell Intel P4600 NVMe SSDs
Status: New
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-scsi mailing list
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2018-12-12 22:31 UTC by David Fugate
Modified: 2019-01-08 15:33 UTC (History)
2 users (show)

See Also:


Attachments
Patch to sys/dev/nvme/nvme_ns.c (440 bytes, patch)
2018-12-12 22:31 UTC, David Fugate
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Fugate 2018-12-12 22:31:12 UTC
Created attachment 200070 [details]
Patch to sys/dev/nvme/nvme_ns.c

Dell-branded Intel P4600 NVMe drives benefit from NVMe 1.3's NOIOB feature. Unfortunately just like Intel DC P4500s, they don't advertise themselves as benefiting from this...

The attached patch adds P4600s to the existing list of old drives which benefit from striping.
Comment 1 chuck 2019-01-07 15:42:12 UTC
Added Differential https://reviews.freebsd.org/D18772
Comment 2 commit-hook freebsd_committer 2019-01-08 15:32:08 UTC
A commit references this bug:

Author: chuck
Date: Tue Jan  8 15:30:57 UTC 2019
New revision: 342862
URL: https://svnweb.freebsd.org/changeset/base/342862

Log:
  Add NVMe drive to NOIOB quirk list

  Dell-branded Intel P4600 NVMe drives benefit from NVMe 1.3's NOIOB
  feature. Unfortunately just like Intel DC P4500s, they don't advertise
  themselves as benefiting from this...

  This changes adds P4600s to the existing list of old drives which
  benefit from striping.

  PR:		233969
  Submitted by:	David Fugate <dave.fugate@gmail.com>
  Reviewed by:	imp, mav
  Approved by:	imp (mentor)
  MFC after:	1 week
  Differential Revision:	https://reviews.freebsd.org/D18772

Changes:
  head/sys/dev/nvme/nvme_ns.c
Comment 3 chuck 2019-01-08 15:33:30 UTC
Thanks for the report!