Bug 233970 - Add small patches to sysutils/ansible 2.7.2
Summary: Add small patches to sysutils/ansible 2.7.2
Status: In Progress
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Nikolai Lifanov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-12-13 00:36 UTC by Timur I. Bakeyev
Modified: 2019-08-08 12:12 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (lifanov)


Attachments
Patch to update the sysutils/ansible port (6.04 KB, patch)
2018-12-13 00:36 UTC, Timur I. Bakeyev
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Timur I. Bakeyev freebsd_committer 2018-12-13 00:36:41 UTC
Dear maintainer!

Please, update the ansible port to the 2.7.2 version.

The corresponding patch is attached to this report.
Comment 1 Timur I. Bakeyev freebsd_committer 2018-12-13 00:36:43 UTC
Created attachment 200071 [details]
Patch to update the sysutils/ansible port
Comment 2 Timur I. Bakeyev freebsd_committer 2018-12-13 00:48:59 UTC
This PR adds 4 small patches to ansible, while they are not in the upstream yet.

patch-lib__ansible__module_utils__facts__virtual__freebsd.py

Rudimentary detection of the virtual platforms, more through version is coming. Catches VMWare at minimum.

patch-lib__ansible__modules__packaging__os__pkgng.py

There is at least one case, when upgrading from 11.1 to 11.2 when pkg asks extra question about OS version mismatch in the repository. As this isn't handled, playbook hangs forever. Adding ASSUME_ALWAYS_YES to the environment addresses that, and possibly other potential issues.

patch-lib__ansible__modules__storage__zfs__zfs.py

- name: Create a new file system by cloning a snapshot
  zfs:
    name: rpool/cloned_fs
    state: present
    origin: rpool@mysnapshot

doesn't work properly, as code assumes that there is at least one level of hierarchy in zpool. But that's not always the case - pool may be dataset as well and have a snapshot.

patch-lib__ansible__playbook__play_context.py

`doas` support in ansible is broken ATM, doesn't handle password authentication properly, cause assumes only challenge-respond auth. This patch should handle both ways properly.
Comment 3 Timur I. Bakeyev freebsd_committer 2019-01-31 22:52:28 UTC
Any update on this? Maintainer timeout already passed...
Comment 4 Nikolai Lifanov freebsd_committer 2019-02-02 00:15:18 UTC
Hi! Sorry, it slipped through the cracks.
Comment 5 Nikolai Lifanov freebsd_committer 2019-02-02 00:25:57 UTC
I'm about to update sysutils/ansible to 2.7.6 and incorporate these patches.
Do these correspond to upstream PRs or commits?

If so, I'd like to grab the patch directly from github so that it makes it
easy to determine which versions it is relevant for.

If not, would you like me to submit pull requests with these on your behalf or would you like to do it?
Comment 6 Walter Schwarzenfeld freebsd_triage 2019-08-08 12:12:28 UTC
Status?