Bug 234033 - x11/libxklavier: depend directly on gettext-runtime
Summary: x11/libxklavier: depend directly on gettext-runtime
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-gnome (Nobody)
Keywords: easy
Depends on:
Reported: 2018-12-15 05:13 UTC by John Hein
Modified: 2021-03-10 19:30 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (gnome)
koobs: merge-quarterly?

[patch] add USES=gettext-runtime (860 bytes, patch)
2018-12-15 05:13 UTC, John Hein
jcfyecrayz: maintainer-approval? (gnome)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description John Hein 2018-12-15 05:13:01 UTC
Created attachment 200128 [details]
[patch] add USES=gettext-runtime

x11/libxklavier links with libintl.so.  It should therefore depend directly on gettext-runtime (rather than indirectly via USE_GNOME knobs).

I'll let the committer decide if this merits a PORTREVISION bump.  I don't think it does since nothing changes in the package.

While here, pet portlint a bit.

  poudriere testport - ok
  portlint - remove a couple warnings, add no new warnings
Comment 1 Walter Schwarzenfeld freebsd_triage 2019-08-08 00:48:20 UTC
Comment 2 Steve Wills freebsd_committer 2021-03-10 19:30:20 UTC
FWIW, libxklavier is explicitly unmaintained and deprecated upstream: