Bug 234033 - x11/libxklavier: depend directly on gettext-runtime
Summary: x11/libxklavier: depend directly on gettext-runtime
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-gnome (Nobody)
URL:
Keywords: easy
Depends on:
Blocks:
 
Reported: 2018-12-15 05:13 UTC by John Hein
Modified: 2025-05-07 19:22 UTC (History)
4 users (show)

See Also:


Attachments
[patch] add USES=gettext-runtime (860 bytes, patch)
2018-12-15 05:13 UTC, John Hein
jcfyecrayz: maintainer-approval? (gnome)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description John Hein 2018-12-15 05:13:01 UTC
Created attachment 200128 [details]
[patch] add USES=gettext-runtime

x11/libxklavier links with libintl.so.  It should therefore depend directly on gettext-runtime (rather than indirectly via USE_GNOME knobs).

I'll let the committer decide if this merits a PORTREVISION bump.  I don't think it does since nothing changes in the package.

While here, pet portlint a bit.

QA:
  poudriere testport - ok
  portlint - remove a couple warnings, add no new warnings
Comment 1 Walter Schwarzenfeld 2019-08-08 00:48:20 UTC
ping!
Comment 2 Steve Wills freebsd_committer freebsd_triage 2021-03-10 19:30:20 UTC
FWIW, libxklavier is explicitly unmaintained and deprecated upstream:

https://www.freedesktop.org/wiki/Software/LibXklavier/
Comment 3 Mark Linimon freebsd_committer freebsd_triage 2025-05-06 04:31:54 UTC
^Triage: reset stale maintainer-feedback flag.

Upstream notes that this software has been discontinued since 2021.

Take to begin the deprecation process.
Comment 4 commit-hook freebsd_committer freebsd_triage 2025-05-07 08:46:36 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=dbac7d1ca87d2c7c11fa6115c5f2ca4449a5c779

commit dbac7d1ca87d2c7c11fa6115c5f2ca4449a5c779
Author:     Mark Linimon <linimon@FreeBSD.org>
AuthorDate: 2025-05-07 08:40:50 +0000
Commit:     Mark Linimon <linimon@FreeBSD.org>
CommitDate: 2025-05-07 08:45:38 +0000

    x11/libxklavier: mark as deprecated and give an expiration date.

    Nothing else in the tree depends on this port.

    PR:     234033
    Hat:    bugmeister (maintainer-feedback timeout > 2 years)

 x11/libxklavier/Makefile | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
Comment 5 Mark Linimon freebsd_committer freebsd_triage 2025-05-07 08:48:32 UTC
^Triage: the port has been marked deprecated (folded into GNOME mainstream a long time ago).

Committed via maintainer-timeout (several years).
Comment 6 Charlie Li freebsd_committer freebsd_triage 2025-05-07 17:50:01 UTC
This fell through the cracks at gnome@, but here is yet another notification that this cannot be removed since parts of both XFCE and Cinnamon still depend on this.
Comment 7 Mark Linimon freebsd_committer freebsd_triage 2025-05-07 19:22:42 UTC
^Triage: commit reverted.  Sorry for jumping the gun.