Created attachment 200140 [details]
The attached patch updates goaccess to 1.3. A couple things
to keep in mind here:
- The location of the conf file has changed. Previously it
was in /usr/local/etc, now it is in /usr/local/etc/goaccess
A message in UPDATING +/- a pkg-message about it may be
helpful for end-users
- The --disable-nls switch was broken. The included patches
Created attachment 200153 [details]
On second thought, HAVE_LIBINTL isn't the right guard here, it's ENABLE_NLS. I've redone the patch with that instead.
Thank you for working on this upgrade and support for NLS!
I had a quick look at your changes and it seems you removed the static files for the goaccess webui. Basically everything under %%PORTDOCS%%%%DOCSDIR%% in the pkg-plist in the ports and upstream everything under resources folder .
I will have a deeper look at the release notes for the upgrade of 1.3 in order to figure out all the changes.
You are correct, they were removed in https://github.com/allinurl/goaccess/commit/61624f02d973c504b0cee5ff81aec6025701158d#diff-c949f93d03f44a4217d7a138f9e2e54a
Makefile.am: don't install resources
Those resources are converted to C and embedded into the final binary
during the build. There is no point in also installing them to
I noticed that you set maintainer-feedback+, but I wasn't sure whether that was a signal to commit. Just to clarify: was that to signal to me that you'd like me to commit it, or was that to log it for yourself to commit?
Correct, it was an approval signal to let you know you can go ahead and commit your own changes. Thank you!
Thanks, Sofian. Would you like an UPDATING and/or pkg-message entry about the conf file location change?
Yes it would be good but I don't have a strong opinion about this. If you do it, you might want to add something similar for the UPDATING entry:
AFFECTS: users of sysutils/goaccess
The configuration location path for has been changed:
Honestly, I have never used a configuration for such command line tool. Agreed it would help the end-users.
A commit references this bug:
Date: Thu Jan 3 21:08:53 UTC 2019
New revision: 489224
Update goaccess to 1.3.
With this release:
- The config file has moved from PREFIX/etc to ETCDIR
- The web assets are no longer installed separately (they
are compiled into the binary so this should not affect
- NLS support (and OPTION) added
pkg-message and UPDATING entry added for conf file location
Approved by: maintainer (sbz)
Fixed. Committed in r489224