Bug 234077 - [NEW PORT] devel/p5-MooX-Locale-Passthrough: Provide API used in translator modules without translating
Summary: [NEW PORT] devel/p5-MooX-Locale-Passthrough: Provide API used in translator m...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Wen Heping
URL:
Keywords: feature, needs-patch, needs-qa
Depends on:
Blocks: 233934
  Show dependency treegraph
 
Reported: 2018-12-16 22:04 UTC by espen
Modified: 2019-01-06 13:11 UTC (History)
4 users (show)

See Also:
koobs: maintainer-feedback? (espen)


Attachments
shar file for devel/p5-MooX-Locale-Passthrough (2.13 KB, text/plain)
2018-12-16 22:04 UTC, espen
no flags Details
Updated shar based on review feedback (1.95 KB, text/plain)
2018-12-16 22:38 UTC, espen
no flags Details
Updated shar based on second review (1.95 KB, text/plain)
2018-12-16 22:50 UTC, espen
no flags Details
Updated shar based on review feedback (1.92 KB, text/plain)
2018-12-17 23:01 UTC, espen
no flags Details
Updated shar based on portlint checks (1.94 KB, text/plain)
2019-01-05 21:38 UTC, espen
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description espen 2018-12-16 22:04:25 UTC
Created attachment 200165 [details]
shar file for devel/p5-MooX-Locale-Passthrough

New port needed to update devel/p5-MooX-Options
Comment 1 Nathan 2018-12-16 22:17:34 UTC
Comment on attachment 200165 [details]
shar file for devel/p5-MooX-Locale-Passthrough

NO_ARCH=	yes
Should go after USE_PERL5 with space

Since pkg-plist is less than 6 items in it list them in Makefile
Comment 2 espen 2018-12-16 22:38:26 UTC
Created attachment 200167 [details]
Updated shar based on review feedback

Updated shar based on review feedback
Comment 3 Nathan 2018-12-16 22:40:05 UTC
Comment on attachment 200167 [details]
Updated shar based on review feedback

XPLIST_FILES=	%%SITE_PERL%%/MooX/Locale/Passthrough.pm \
X		%%PERL5_MAN3%%/MooX::Locale::Passthrough.3.gz
Goes after USES_

See: https://www.freebsd.org/doc/en/books/porters-handbook/porting-order.html
Comment 4 espen 2018-12-16 22:50:44 UTC
Created attachment 200168 [details]
Updated shar based on second review

Updated shar based on second review
Comment 5 Kubilay Kocak freebsd_committer freebsd_triage 2018-12-17 05:31:43 UTC
RUN_DEPENDS don't need to be added to TEST_DEPENDS
Comment 6 espen 2018-12-17 23:01:12 UTC
Created attachment 200207 [details]
Updated shar based on review feedback

Removed superfluous TEST_DEPENDS
Comment 7 wen 2018-12-27 06:40:55 UTC
There are some errors in your Makefile.
Would you use `portlint -AC` to check it ?

wen
Comment 8 espen 2019-01-05 21:38:49 UTC
Created attachment 200812 [details]
Updated shar based on portlint checks
Comment 9 commit-hook freebsd_committer 2019-01-06 13:09:16 UTC
A commit references this bug:

Author: wen
Date: Sun Jan  6 13:08:40 UTC 2019
New revision: 489489
URL: https://svnweb.freebsd.org/changeset/ports/489489

Log:
  MooX::Locale::Passthrough is made to allow CPAN modules use translator API
  without adding heavy dependencies (external software) or requirements
  (operating resulting solution).

  WWW: https://metacpan.org/release/MooX-Locale-Passthrough

  PR:		234077
  Submitted by:	espen@tagestad.no

Changes:
  head/devel/Makefile
  head/devel/p5-MooX-Locale-Passthrough/
  head/devel/p5-MooX-Locale-Passthrough/Makefile
  head/devel/p5-MooX-Locale-Passthrough/distinfo
  head/devel/p5-MooX-Locale-Passthrough/pkg-descr