Bug 234286 - graphics/GraphicsMagick should NOT have the trio-option
Summary: graphics/GraphicsMagick should NOT have the trio-option
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-12-23 02:54 UTC by Mikhail Teterin
Modified: 2019-01-05 23:30 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (sunpoet)

Attachments
Remove the TRIO-option from GraphicsMagick (1.44 KB, patch)
2018-12-23 02:54 UTC, Mikhail Teterin 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mikhail Teterin freebsd_committer freebsd_triage 2018-12-23 02:54:35 UTC 
Created attachment 200382 [details]
Remove the TRIO-option from GraphicsMagick

For starters, the option is currently broken - because devel/trio does not install the libtrio.so symlink.

However, even if the devel/trio worked, it is unnecessary. According to GM's own README, the only thing GM would use it for is to substitute vsnprintf if the OS libraries do not provide it.

FreeBSD does provide vsnprintf(3) -- so GM does not need the TRIO option.
Comment 1 Po-Chuan Hsieh freebsd_committer freebsd_triage 2019-01-05 23:21:20 UTC 
Committed. Thanks!
Comment 2 commit-hook freebsd_committer freebsd_triage 2019-01-05 23:28:02 UTC 
A commit references this bug:

Author: sunpoet
Date: Sat Jan  5 23:27:34 UTC 2019
New revision: 489419
URL: https://svnweb.freebsd.org/changeset/ports/489419

Log:
  Remove the unnecessary TRIO option

  - Bump PORTREVISION for dependency change

  PR:		234286
  Submitted by:	mi

Changes:
  head/graphics/GraphicsMagick/Makefile
Comment 3 Mikhail Teterin freebsd_committer freebsd_triage 2019-01-05 23:30:24 UTC 
> Bump PORTREVISION for dependency change

The dependency has always been optional - port would not build with it on - the PORTREVISION bump was not necessary.

Countless computers worldwide will now be performing a useless upgrade of the port :( Sigh...