Bug 234440 - math/clrng: fix build with GCC-based architectures
Summary: math/clrng: fix build with GCC-based architectures
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Johannes M Dieterich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-12-27 10:57 UTC by Piotr Kubaj
Modified: 2018-12-28 21:34 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (jmd)


Attachments
patch (365 bytes, patch)
2018-12-27 10:57 UTC, Piotr Kubaj
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer 2018-12-27 10:57:14 UTC
Created attachment 200554 [details]
patch

Building with GCC requires adding -Wno-expansion-to-defined to CFLAGS.

src/library/../cl/include/private/Random123/features/compilerfeatures.h:265:5: error: this use of "defined" may not be portable [-Wexpansion-to-defin
ed]
 #if R123_USE_CXX11_CONSTEXPR
     ^~~~~~~~~~~~~~~~~~~~~~~~
In file included from src/library/../cl/include/private/philox432.c.h:41,
                 from src/library/philox432.c:51:


Tested on powerpc64 and amd64.

Hardware sponsored by IntegriCloud.
Comment 1 commit-hook freebsd_committer 2018-12-28 21:32:59 UTC
A commit references this bug:

Author: jmd
Date: Fri Dec 28 21:32:12 UTC 2018
New revision: 488629
URL: https://svnweb.freebsd.org/changeset/ports/488629

Log:
  math/clrng: fix with GCC based architectures

  PR:	234440
  Submitted by:	Piotr Kubaj

Changes:
  head/math/clrng/Makefile
Comment 2 Johannes M Dieterich freebsd_committer 2018-12-28 21:34:06 UTC
Applied, thanks!