Bug 234492 - print/py-fonttools: Update to 3.34.2, Enable optional features
Summary: print/py-fonttools: Update to 3.34.2, Enable optional features
Status: Closed Feedback Timeout
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Po-Chuan Hsieh
URL:
Keywords:
Depends on: 234491
Blocks:
  Show dependency tree / graph
 
Reported: 2018-12-29 16:56 UTC by Ting-Wei Lan
Modified: 2019-04-30 16:01 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (sunpoet)

Attachments
print/py-fonttools: 3.33.0 -> 3.34.2 (1.59 KB, patch)
2018-12-29 16:56 UTC, Ting-Wei Lan 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ting-Wei Lan 2018-12-29 16:56:58 UTC 
Created attachment 200608 [details]
print/py-fonttools: 3.33.0 -> 3.34.2

I am going to update x11-fonts/py-fontmake from 1.7 to 1.8. This new version of fontmake stops using x11-fonts/py-ufoLib and starts requiring print/py-fonttools to have optional 'ufo', 'lxml', 'unicode' featues. Therefore, I have to add more RUN_DEPENDS to print/py-fonttools first.

Note that this patch lists devel/py-fs >= 2.1.1 in RUN_DEPENDS, but it is still at version 0.5.4 in ports. The patch can only be committed after devel/py-fs is updated.
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2018-12-30 01:22:36 UTC 
Can these optional features be turned into OPTIONS, enabled by default (OPTIONS_DEFAULT)
Comment 2 Ting-Wei Lan 2018-12-31 09:11:05 UTC 
(In reply to Kubilay Kocak from comment #1)
The setup.py of fonttools defines 8 optional features, do you think we have to convert all these optional features into 8 ports options?
Comment 3 Kubilay Kocak freebsd_committer freebsd_triage 2018-12-31 09:31:32 UTC 
(In reply to Ting-Wei Lan from comment #2)

That depends on the nature and context of the options, and whether or not multiple optional features/components can come under the banner of a single OPTION because they are relevant together.

I see that upstream has already grouped them up into ufo, lxml, woff, unicode, graphite, interpolatable, plot and type1, some of which only apply to specific OS's, so this would be a good place to start

For any optional feature that you think might be valuable/relevant to the majority of users, and are fairly lightweight in terms of additional dependencies, you could consider just adding them in unconditionally. 'unicode' looks like one.
Comment 4 Po-Chuan Hsieh freebsd_committer freebsd_triage 2019-01-24 17:02:21 UTC 
The patch is outdated since print/py-fonttools is 3.36.0 now.

BTW, you do not have to add all this options to py-fonttools, instead, you could just add the dependencies to py-fontmake.
The main reason is, the options you need for py-fontmake may not always be enabled by default in py-fonttools.

At last, I removed the "Blocks" section because those 2 PRs only require print/py-fonttools 3.32.0 (which is true before this PR).
Comment 5 Ting-Wei Lan 2019-03-03 04:23:14 UTC 
(In reply to Sunpoet Po-Chuan Hsieh from comment #4)
It does block those 2 PRs because they both depend on 'ufo' feature. If fonttools doesn't pull in dependencies required for 'ufo' feature by default, those 2 ports cannot work.
Comment 6 Po-Chuan Hsieh freebsd_committer freebsd_triage 2019-03-26 18:26:21 UTC 
As I said in comment #4, the patch is outdated. And you should first add what you want to py-fontmake. I'm going to remove Blocks again and close this PR.