Bug 234551 - multimedia/mythtv: Update to 29.1-1104 (pre-0.30.0). Fixes build on FreeBSD 12.0
Summary: multimedia/mythtv: Update to 29.1-1104 (pre-0.30.0). Fixes build on FreeBSD 12.0
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: amd64 Any
: --- Affects Some People
Assignee: freebsd-ports-bugs mailing list
URL:
Keywords: needs-patch, needs-qa
Depends on:
Blocks:
 
Reported: 2019-01-01 23:18 UTC by fernando.e.vilas
Modified: 2019-01-12 17:42 UTC (History)
1 user (show)

See Also:
koobs: maintainer-feedback? (fernando.e.vilas)
koobs: merge-quarterly?


Attachments
Patch to cc25495 (125.73 KB, patch)
2019-01-01 23:18 UTC, fernando.e.vilas
no flags Details | Diff
Patch to 5c3257e (146.03 KB, patch)
2019-01-04 03:31 UTC, fernando.e.vilas
no flags Details | Diff
Update patch to include a file only used by the dependent port mythtv-frontend (146.72 KB, patch)
2019-01-07 03:28 UTC, fernando.e.vilas
koobs: maintainer-approval+
Details | Diff
Patch multimedia/mythtv-frontend to make it build against this update (14.44 KB, patch)
2019-01-07 03:28 UTC, fernando.e.vilas
koobs: maintainer-approval+
Details | Diff
Updated patch to address comments from Tobias (146.68 KB, patch)
2019-01-12 17:42 UTC, fernando.e.vilas
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description fernando.e.vilas 2019-01-01 23:18:13 UTC
Created attachment 200688 [details]
Patch to cc25495
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2019-01-02 05:08:46 UTC
Thank you Fernando

Could you please update the patch to:

- Use ${PREFIX} instead of hardcoded /usr/local
- Remove the BROKEN line rather than commenting it
- Confirm the change passes QA (portlint, poudriere in particular)
Comment 2 fernando.e.vilas 2019-01-04 03:31:22 UTC
Created attachment 200758 [details]
Patch to 5c3257e

I think I got the Makefile and the poudriere stuff fixed. From portlint, there are still 3 warnings:

WARN: Makefile: unless this is a master port, MAINTAINER has to be set by "=", not by "?=".
WARN: Makefile: unless this is a master port, COMMENT has to be set by "=", not by "?=".
WARN: /poudriere/ports/subversive/multimedia/mythtv/files/patch-CVE-2016-10191: patch was not generated using ``make makepatch''.  It is recommended to use ``make makepatch'' when you need to [re-]generate a patch to ensure proper patch format.

1&2) I can update these if required, but I am not sure if this is a master port or not...  And I definitely don't want to sign up as maintainer, just trying to help out the community with the work I had to do to fix my mythtv jail after a 12.0 update.
3) I am not really sure about this one. It is an old patch against the FFmpeg includes that applied cleanly, so I kept it when I had to delete the others. This patch has been in the port for a while.
Comment 3 Kubilay Kocak freebsd_committer freebsd_triage 2019-01-04 04:00:37 UTC
(In reply to fernando.e.vilas from comment #2)

Thank you for doing that (QA) Fernando.

Those warnings are fine (in this case).

`find /usr/ports -exec grep -HC3 'mythtv' {} + |grep MASTERDIR` reports the following as the only sub port:

multimedia/mythtv-frontend/Makefile:MASTERDIR=${.CURDIR}/../../multimedia/mythtv

It would be great if you could poudriere test that port, with your patch applied to multimedia/mythtv, to ensure it continued to build/package as well with the change to the parent port.
Comment 4 fernando.e.vilas 2019-01-07 03:28:05 UTC
Created attachment 200851 [details]
Update patch to include a file only used by the dependent port mythtv-frontend
Comment 5 fernando.e.vilas 2019-01-07 03:28:59 UTC
Created attachment 200852 [details]
Patch multimedia/mythtv-frontend to make it build against this update
Comment 6 fernando.e.vilas 2019-01-07 03:31:05 UTC
I updated the patch file in multimedia/mythtv that is used by multimedia/mythtv-frontend to build.

I also had to update pkg-plist for multimedia/mythtv-frontend, so I included that as a separate patch in the bug.
Comment 7 Kubilay Kocak freebsd_committer freebsd_triage 2019-01-07 04:14:17 UTC
Comment on attachment 200851 [details]
Update patch to include a file only used by the dependent port mythtv-frontend

Approved by: portmgr (unmaintained port)
Comment 8 Kubilay Kocak freebsd_committer freebsd_triage 2019-01-07 04:14:22 UTC
Comment on attachment 200852 [details]
Patch multimedia/mythtv-frontend to make it build against this update

Approved by: portmgr (unmaintained port)
Comment 9 Kubilay Kocak freebsd_committer freebsd_triage 2019-01-07 04:19:02 UTC
@Fernando, Thank you for the updates

This issue says 'fixes build on FreeBSD 12.0' but the port is currently unconditionally marked BROKEN, which applies to all versions. 

Could you clarify/detail whether QA (poudriere) was run only on 12.0, or another/other version(s)?

It would be great to get QA results for 11.2 and CURRENT as well, so we can leave the package marked BROKEN for those versions if they remain broken, and otherwise be confident that the poyrt/package builds on all currently supported versions

I understand this is a rather large/complex port with many dependencies, and as such takes time/resources to QA, though since this update will/should be merged to the quarterly branch, careful QA is particularly important
Comment 10 Tobias Kortkamp freebsd_committer 2019-01-07 06:18:50 UTC
Comment on attachment 200851 [details]
Update patch to include a file only used by the dependent port mythtv-frontend

- Do *not* re-add GH_TAGNAME here.  It leads to mistakes like the
  one fixed in ports r456874.

  Use the procedure in the Porter's Handbook [1] to derive a proper
  DISTVERSION, DISTVERSIONSUFFIX for 5c3257e instead.

- PORTREVISION must be reset to 0 when bumping the version
 
+BUILD_DEPENDS=	yasm:devel/yasm \
+		${PREFIX}/include/linux/input.h:devel/evdev-proto

This is incorrect and should be LOCALBASE, not PREFIX.  They can differ. 
LOCALBASE is where dependencies come from, PREFIX is where the port installs 
into.  

[1] https://www.freebsd.org/doc/en/books/porters-handbook/makefile-distfiles.html#makefile-master_sites-github-ex5
Comment 11 fernando.e.vilas 2019-01-12 17:42:32 UTC
Created attachment 201071 [details]
Updated patch to address comments from Tobias

I have only tested this at runtime on my 12.0-RELEASE jail, but I can confirm that it successfully builds in jails for 13-CURRENT and 11.2-RELEASE.