Bug 234558 - net/py-netifaces: invalid errno check
Summary: net/py-netifaces: invalid errno check
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Muhammad Moinur Rahman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-01-02 06:13 UTC by Alan Somers
Modified: 2019-01-03 11:55 UTC (History)
0 users

See Also:
bofh: maintainer-feedback+
bofh: merge-quarterly+

Attachments
Fix invalid errno check in netifaces.gateways() (1.33 KB, patch)
2019-01-02 06:14 UTC, Alan Somers 		asomers: maintainer-approval?
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alan Somers freebsd_committer freebsd_triage 2019-01-02 06:13:49 UTC 
An invalid errno check in netifaces sends netifaces.gateways() into an infinite loop.  This renders iocage-1.0 unusable.

Upstream issue: https://github.com/al45tair/netifaces/issues/28
Upstream PR: https://github.com/al45tair/netifaces/pull/29
Iocage issue: https://github.com/iocage/iocage/issues/766

Because this is a blocker for iocage, I suggest patching it in the ports tree, rather than waiting for a new release from upstream.
Comment 1 Alan Somers freebsd_committer freebsd_triage 2019-01-02 06:14:24 UTC 
Created attachment 200694 [details]
Fix invalid errno check in netifaces.gateways()
Comment 2 commit-hook freebsd_committer freebsd_triage 2019-01-02 07:43:55 UTC 
A commit references this bug:

Author: bofh
Date: Wed Jan  2 07:43:06 UTC 2019
New revision: 489059
URL: https://svnweb.freebsd.org/changeset/ports/489059

Log:
  net/py-netifaces: Update version 0.10.6=>0.10.7

  - Fix invalid errno check in netifaces.gateways() [1]

  PR:		234558 [1]
  Submitted by:	asomers [1]

Changes:
  head/net/py-netifaces/Makefile
  head/net/py-netifaces/distinfo
  head/net/py-netifaces/files/
  head/net/py-netifaces/files/patch-netifaces.c
Comment 3 Kubilay Kocak freebsd_committer freebsd_triage 2019-01-02 12:04:38 UTC 
Re-open for MFH (bugfix only version update)
Comment 4 Muhammad Moinur Rahman freebsd_committer freebsd_triage 2019-01-02 13:25:46 UTC 
(In reply to Kubilay Kocak from comment #3)
Hi Koobs,
As I have already committed do I need to notify ports-secteam@ or portmgr@ along with this bug or just a positive feedback notifies the team?
Comment 5 Kubilay Kocak freebsd_committer freebsd_triage 2019-01-02 13:32:44 UTC 
Technically only security updates require explicit approval (others are blanket approved), but it's nice to get approval as sometimes there are extra considerations with a stable branch that's further out of date then head.

In this case the change doesn't bump the version, so netifaces dependents shouldn't have an issue, and this fixes a very single narrowly scoped code bug.

Personally, I would merge:

Approved by: ports-secteam (blanket, bugfix)

But, if you'd like to wait or get explicit approval, you can request approval here with: Attachment -> Details -> maintainer-approval ? ports-secteam@...
Comment 6 commit-hook freebsd_committer freebsd_triage 2019-01-03 11:33:22 UTC 
A commit references this bug:

Author: bofh
Date: Thu Jan  3 11:32:52 UTC 2019
New revision: 489164
URL: https://svnweb.freebsd.org/changeset/ports/489164

Log:
  net/py-netifaces: Merge Quarterly

  - Port BUMP due to mistake in merge

  PR:		234558
  Reported by:	koobs
  Approved by:	ports-secteam (blanket, bugfix)
  MFH:		2019Q1

Changes:
  head/net/py-netifaces/Makefile