Bug 234584 - iwm(4): need to mention the iwm7265Dfw module
Summary: iwm(4): need to mention the iwm7265Dfw module
Status: Closed FIXED
Alias: None
Product: Documentation
Classification: Unclassified
Component: Books & Articles (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Piotr Kubaj
URL:
Keywords: IntelNetworking, easy, needs-patch
Depends on:
Blocks:
 
Reported: 2019-01-02 22:07 UTC by doug
Modified: 2023-02-04 17:02 UTC (History)
6 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description doug 2019-01-02 22:07:23 UTC
iwm(4) man page should reference iwm7265Dfw rather than iwm7265fw
Comment 1 Yuri Pankov freebsd_committer freebsd_triage 2019-01-03 06:20:41 UTC
Note that both iwm7265fw and iwm7265Dfw exist, so the iwm7265Dfw should be added, rather than replacing iwm7265fw.
Comment 2 Bjoern A. Zeeb freebsd_committer freebsd_triage 2019-01-07 14:35:02 UTC
Hmm I can see that this was done .. just not in the place you are looking:

https://svnweb.freebsd.org/base?view=revision&revision=314080

I am not sure why we do have two man pages;  would it make sense to fold this information all together into iwm.4 and "harmonize" it between sections?
Comment 3 Piotr Kubaj freebsd_committer freebsd_triage 2023-02-03 17:24:13 UTC
Review posted at https://reviews.freebsd.org/D38374.
Comment 4 commit-hook freebsd_committer freebsd_triage 2023-02-04 13:15:23 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=29fa34aadbd3d93343573220a521caa0c248682d

commit 29fa34aadbd3d93343573220a521caa0c248682d
Author:     Piotr Kubaj <pkubaj@FreeBSD.org>
AuthorDate: 2023-02-04 13:12:56 +0000
Commit:     Piotr Kubaj <pkubaj@FreeBSD.org>
CommitDate: 2023-02-04 13:15:00 +0000

    iwm(4), iwmfw(4): mention iwm7265Dfw

    Correct documentation by mentioning iwm7265Dfw.

    PR:     234584
    Differential review:    https://reviews.freebsd.org/D38374
    Approved by:    erj

 share/man/man4/iwm.4   | 4 +++-
 share/man/man4/iwmfw.4 | 3 ++-
 2 files changed, 5 insertions(+), 2 deletions(-)
Comment 5 Piotr Kubaj freebsd_committer freebsd_triage 2023-02-04 13:16:21 UTC
Fix committed.
Comment 6 Li-Wen Hsu freebsd_committer freebsd_triage 2023-02-04 13:23:33 UTC
(In reply to Piotr Kubaj from comment #5)
Thanks and I think it's worth to be MFC'd?
Comment 7 commit-hook freebsd_committer freebsd_triage 2023-02-04 17:02:04 UTC
A commit in branch stable/13 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=97ab40b1d7b559fa5fc3b3c18f61b38dcbca6090

commit 97ab40b1d7b559fa5fc3b3c18f61b38dcbca6090
Author:     Piotr Kubaj <pkubaj@FreeBSD.org>
AuthorDate: 2023-02-04 13:12:56 +0000
Commit:     Piotr Kubaj <pkubaj@FreeBSD.org>
CommitDate: 2023-02-04 17:00:56 +0000

    iwm(4), iwmfw(4): mention iwm7265Dfw

    Correct documentation by mentioning iwm7265Dfw.

    PR:     234584
    Differential review:    https://reviews.freebsd.org/D38374
    Approved by:    erj

    (cherry picked from commit 29fa34aadbd3d93343573220a521caa0c248682d)

 share/man/man4/iwm.4   | 4 +++-
 share/man/man4/iwmfw.4 | 3 ++-
 2 files changed, 5 insertions(+), 2 deletions(-)
Comment 8 commit-hook freebsd_committer freebsd_triage 2023-02-04 17:02:05 UTC
A commit in branch stable/12 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=9fcc1b60b7fa9747510283519ede2accafc551dd

commit 9fcc1b60b7fa9747510283519ede2accafc551dd
Author:     Piotr Kubaj <pkubaj@FreeBSD.org>
AuthorDate: 2023-02-04 13:12:56 +0000
Commit:     Piotr Kubaj <pkubaj@FreeBSD.org>
CommitDate: 2023-02-04 17:01:44 +0000

    iwm(4), iwmfw(4): mention iwm7265Dfw

    Correct documentation by mentioning iwm7265Dfw.

    PR:     234584
    Differential review:    https://reviews.freebsd.org/D38374
    Approved by:    erj

    (cherry picked from commit 29fa34aadbd3d93343573220a521caa0c248682d)
    (cherry picked from commit 97ab40b1d7b559fa5fc3b3c18f61b38dcbca6090)

 share/man/man4/iwm.4   | 4 +++-
 share/man/man4/iwmfw.4 | 3 ++-
 2 files changed, 5 insertions(+), 2 deletions(-)