Bug 234607 - devel/gitg: Crash on exit if built with -fstack-protector-all
Summary: devel/gitg: Crash on exit if built with -fstack-protector-all
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Koop Mast
URL: https://gitlab.gnome.org/GNOME/gitg/i...
Keywords: crash, easy, needs-qa
Depends on:
Blocks:
 
Reported: 2019-01-04 10:42 UTC by Ivan Rozhuk
Modified: 2019-02-24 15:38 UTC (History)
1 user (show)

See Also:
kwm: merge-quarterly-

Attachments
patch (835 bytes, patch)
2019-01-04 10:42 UTC, Ivan Rozhuk 		no flags Details | Diff
update patch (1003 bytes, patch)
2019-01-04 12:09 UTC, Ivan Rozhuk 		rozhuk.im: maintainer-approval?
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ivan Rozhuk 2019-01-04 10:42:09 UTC 
Created attachment 200763 [details]
patch

gitg: crash on exit if build with -fstack-protector-all
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2019-01-04 10:47:40 UTC 
Thank you for the report and patch (and reporting it upstream)

Could you please include upstream references in the patch header as a comment:

# gitg crash on exit if built with -fstack-protector-all
# https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=234607
# https://gitlab.gnome.org/GNOME/gitg/issues/171
Comment 2 Ivan Rozhuk 2019-01-04 12:09:00 UTC 
Created attachment 200764 [details]
update patch
Comment 3 Ivan Rozhuk 2019-02-11 14:03:53 UTC 
ping
Comment 4 commit-hook freebsd_committer freebsd_triage 2019-02-24 15:37:18 UTC 
A commit references this bug:

Author: kwm
Date: Sun Feb 24 15:36:34 UTC 2019
New revision: 493768
URL: https://svnweb.freebsd.org/changeset/ports/493768

Log:
  Fix a crash on exit if build with -fstack-protector-all.

  PR:		234607
  Submitted by:	rozhuk.im@gmail.com

Changes:
  head/devel/gitg/Makefile
  head/devel/gitg/files/
  head/devel/gitg/files/patch-libgitg_gitg-repository-list-box.vala