Bug 234736 - math/reduce, math/reduce-psl: Do not set CONFIGURE_ARGS twice
Summary: math/reduce, math/reduce-psl: Do not set CONFIGURE_ARGS twice
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Pedro F. Giffuni
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2019-01-08 11:02 UTC by Tobias Kortkamp
Modified: 2019-01-08 15:24 UTC (History)
1 user (show)

See Also:
pfg: maintainer-feedback+


Attachments
math__reduce.diff (912 bytes, patch)
2019-01-08 11:02 UTC, Tobias Kortkamp
tobik: maintainer-approval? (pfg)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Kortkamp freebsd_committer 2019-01-08 11:02:33 UTC
Created attachment 200908 [details]
math__reduce.diff

The first CONFIGURE_ARGS is being overwritten by the second one.  Since the
build appears to succeed anyway there seems to be little point in keeping it.

Also removes WRKSRC since it is set to ${WRKDIR}/${DISTNAME} by default already.
Comment 1 Pedro F. Giffuni freebsd_committer 2019-01-08 15:13:54 UTC
Approved, thanks!
Comment 2 commit-hook freebsd_committer 2019-01-08 15:23:43 UTC
A commit references this bug:

Author: tobik
Date: Tue Jan  8 15:22:53 UTC 2019
New revision: 489704
URL: https://svnweb.freebsd.org/changeset/ports/489704

Log:
  math/reduce{,-psl}: Drop unused variables

  WRKSRC is set to the default value, CONFIGURE_ARGS is overwritten
  later and is not needed.

  PR:		234736
  Approved by:	pfg (maintainer)

Changes:
  head/math/reduce/Makefile
  head/math/reduce-psl/Makefile
Comment 3 Tobias Kortkamp freebsd_committer 2019-01-08 15:24:04 UTC
Committed. Thanks! :)