Bug 234762 - www/node, www/node10: refuses to build with system openssl on 12.x
Summary: www/node, www/node10: refuses to build with system openssl on 12.x
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Bradley T. Hughes
URL:
Keywords:
Depends on: 235311
Blocks:
  Show dependency treegraph
 
Reported: 2019-01-08 18:21 UTC by Dmitry Marakasov
Modified: 2019-01-30 10:30 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (bhughes)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Marakasov freebsd_committer 2019-01-08 18:21:01 UTC
/usr/ports/www/node % WITHOUT=BUNDLED_SSL make    
===>  node-11.6.0 node.js requires openssl 1.1.0, add
DEFAULT_VERSIONS+=ssl=openssl111 to /etc/make.conf or enable BUNDLED_SSL
option.
*** Error code 1

This IGNORE is incorrect, as FreeBSD 12+ indeed has new openssl
Comment 1 Bradley T. Hughes freebsd_committer 2019-01-23 14:29:11 UTC
Indeed! I'm looking at the options now, and am considering changing the defaults on >=12.
Comment 2 Bradley T. Hughes freebsd_committer 2019-01-23 21:19:39 UTC
Node.js 10.x LTS also complains unnecessarily, I will fix both ports.
Comment 3 commit-hook freebsd_committer 2019-01-23 21:21:25 UTC
A commit references this bug:

Author: bhughes
Date: Wed Jan 23 21:21:14 UTC 2019
New revision: 491059
URL: https://svnweb.freebsd.org/changeset/ports/491059

Log:
  www/node10: disable BUNDLED_SSL by default on FreeBSD >=12

  Change the default options on FreeBSD >=12 since OpenSSL 1.1.1 is
  available in the base system. Bump PORTREVISION due to teh change in
  defaults.

  While here, convert the port to use BROKEN_SSL, taking care to set
  BROKEN_SSL+=base when appropriate.

  PR:		234762
  Reported by:	amdmi3
  Sponsored by:	Miles AS

Changes:
  head/www/node10/Makefile
Comment 4 commit-hook freebsd_committer 2019-01-23 21:23:28 UTC
A commit references this bug:

Author: bhughes
Date: Wed Jan 23 21:22:58 UTC 2019
New revision: 491060
URL: https://svnweb.freebsd.org/changeset/ports/491060

Log:
  www/node: disable BUNDLED_SSL by default on FreeBSD >=12

  Change the default options on FreeBSD >=12 since OpenSSL 1.1.1 is
  available in the base system. Bump PORTREVISION due to the change in
  defaults.

  While here, convert the port to use BROKEN_SSL, taking care to set
  BROKEN_SSL+=base when appropriate.

  PR:		234762
  Reported by:	amdmi3
  Sponsored by:	Miles AS

Changes:
  head/www/node/Makefile