Bug 234776 - editors/libreoffice: Add support for powerpc and powerpcspe
Summary: editors/libreoffice: Add support for powerpc and powerpcspe
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-office mailing list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-01-09 04:19 UTC by Justin Hibbits
Modified: 2019-02-05 18:05 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (office)


Attachments
Patch adding powerpc and powerpcspe to libreoffice (3.26 KB, patch)
2019-01-09 04:19 UTC, Justin Hibbits
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Hibbits freebsd_committer 2019-01-09 04:19:08 UTC
Created attachment 200938 [details]
Patch adding powerpc and powerpcspe to libreoffice

Only minor additions are needed on top of the powerpc64 patch to enable building for powerpc and powerpcspe.  Test-built on powerpcspe.

The files/patch-powerpc64 can/should probably be renamed to patch-powerpc since it now covers all 3 powerpc architectures.
Comment 1 Justin Hibbits freebsd_committer 2019-01-25 03:01:33 UTC
It turns out gcc already defines __NO_FPRS__ for powerpcspe, so that part of the patch is redundant.
Comment 2 commit-hook freebsd_committer 2019-02-05 17:46:21 UTC
A commit references this bug:

Author: lwhsu
Date: Tue Feb  5 17:46:04 UTC 2019
New revision: 492260
URL: https://svnweb.freebsd.org/changeset/ports/492260

Log:
  Add support for powerpc and powerpcspe

  PR:		234776
  Submitted by:	jhibbits

Changes:
  head/editors/libreoffice/Makefile
  head/editors/libreoffice/files/patch-powerpc
  head/editors/libreoffice/files/patch-powerpc64
Comment 3 Li-Wen Hsu freebsd_committer 2019-02-05 17:48:44 UTC
(In reply to Justin Hibbits from comment #1)
Do you mean this section in Makefile?

CXXFLAGS_powerpcspe=    -D__NO_FPRS

Just wanted to make sure, gcc defines __NO_FPRS__ or __NO_FPRS ?
Comment 4 Justin Hibbits freebsd_committer 2019-02-05 17:54:46 UTC
GCC defines __NO_FPRS__, and that addition was a typo (I had meant __NO_FPRS__ in that define, so that just goes to show that since it builds fine on powerpcspe anyway, it's unnecessary).

That Makefile change was unnecessary, and I should've removed it.
Comment 5 commit-hook freebsd_committer 2019-02-05 18:04:45 UTC
A commit references this bug:

Author: lwhsu
Date: Tue Feb  5 18:04:34 UTC 2019
New revision: 492263
URL: https://svnweb.freebsd.org/changeset/ports/492263

Log:
  Remove unnecessary CXXFLAGS for powerpcspe

  gcc already defineds the correct one.

  PR:		234776
  Submitted by:	jhibbits

Changes:
  head/editors/libreoffice/Makefile