Bug 234791 - sysutils/node_exporter: Add license file, tests, docs and examples
Summary: sysutils/node_exporter: Add license file, tests, docs and examples
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs mailing list
URL: https://reviews.freebsd.org/D18792
Keywords: needs-qa, patch
Depends on:
Blocks:
 
Reported: 2019-01-09 15:50 UTC by Mateusz Piotrowski
Modified: 2019-01-09 15:50 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (ports)


Attachments
Patch (4.09 KB, patch)
2019-01-09 15:50 UTC, Mateusz Piotrowski
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mateusz Piotrowski freebsd_committer 2019-01-09 15:50:25 UTC
Created attachment 200957 [details]
Patch

- Define LICENSE_FILE
- Sort variables
- Add a do-test target and prepare a testing environment.  One test is skipped
  at the moment due to a problem with detecting procfs(5) on FreeBSD.
- Install documentation and examples.
- Change pkg-descr to better match upstream's README.

I am not sure about a couple of things, however:

    Is it fine to use USES=gmake instead of TEST_DEPENDS=gmake:devel/gmake? USES=gmake adds a dependency to the build process, which is not ideal.
    The whole pre-test target is rather hacky. I was unable to come up with a prettier solution though. Go is a little bit hard to tame.