Bug 234825 - audio/audacity: Sets DYNLOAD_BUILD_DEPENDS twice
Summary: audio/audacity: Sets DYNLOAD_BUILD_DEPENDS twice
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tobias Kortkamp
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-01-10 15:58 UTC by Tobias Kortkamp
Modified: 2019-01-11 20:57 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (xxjack12xx)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Kortkamp freebsd_committer 2019-01-10 15:58:11 UTC
The port currently sets DYNLOAD_BUILD_DEPENDS twice.  The second
one overwrites the first one.

DYNLOAD_BUILD_DEPENDS=  ${LOCALBASE}/libdata/pkgconfig/libavcodec.pc:multimedia/ffmpeg
DYNLOAD_BUILD_DEPENDS=  ${LOCALBASE}/include/lame/lame.h:audio/lame

Something is not quite right here and in the end DYNLOAD_BUILD_DEPENDS
is only set to ${LOCALBASE}/include/lame/lame.h:audio/lame

Should the two DYNLOAD_BUILD_DEPENDS be concatenated or should the
first DYNLOAD_BUILD_DEPENDS be removed?  What is the right resolution
here?
Comment 1 xxjack12xx 2019-01-11 20:47:32 UTC
It should be concatenated.

Index: Makefile
===================================================================
--- Makefile    (revision 489993)
+++ Makefile    (working copy)
@@ -83,11 +83,11 @@
 DOCS_BUILD_DEPENDS=    docbook-to-man:textproc/docbook-to-man \
                        docbook2man:textproc/docbook-utils

-DYNLOAD_BUILD_DEPENDS= ${LOCALBASE}/libdata/pkgconfig/libavcodec.pc:multimedia/ffmpeg
-DYNLOAD_BUILD_DEPENDS= ${LOCALBASE}/include/lame/lame.h:audio/lame
+DYNLOAD_BUILD_DEPENDS= ${LOCALBASE}/libdata/pkgconfig/libavcodec.pc:multimedia/ffmpeg \
+                       ${LOCALBASE}/include/lame/lame.h:audio/lame
 DYNLOAD_CONFIGURE_ENABLE=      dynamic-loading
-DYNLOAD_CPPFLAGS=              -I${LOCALBASE}/include  # for audio/lame using
-DYNLOAD_LDFLAGS=               -L${LOCALBASE}/lib      # for audio/lame using
+DYNLOAD_CPPFLAGS=              -I${LOCALBASE}/include  # for audio/lame
+DYNLOAD_LDFLAGS=               -L${LOCALBASE}/lib      # for audio/lame

 FFMPEG_CONFIGURE_WITH= ffmpeg=system
 FFMPEG_LIB_DEPENDS=    libavcodec.so:multimedia/ffmpeg
Comment 2 xxjack12xx 2019-01-11 20:49:29 UTC
the dynload is to make ffmpeg work properly with audacity so that's needed but it also requires ffmpeg to be enabled/installed.
Comment 3 Tobias Kortkamp freebsd_committer 2019-01-11 20:57:28 UTC
Ok, committed. Thanks!
Comment 4 commit-hook freebsd_committer 2019-01-11 20:57:56 UTC
A commit references this bug:

Author: tobik
Date: Fri Jan 11 20:57:19 UTC 2019
New revision: 490015
URL: https://svnweb.freebsd.org/changeset/ports/490015

Log:
  audio/audacity: Do not set DYNLOAD_BUILD_DEPENDS twice

  To resolve this, concatenate the two values since this is what was
  originally intended.  Fix some comments while here.

  PR:		234825
  Submitted by:	xxjack12xx@gmail.com (maintainer)

Changes:
  head/audio/audacity/Makefile