Bug 234887 - [exp-run] with Clang modified to emit DWARF4 by default
Summary: [exp-run] with Clang modified to emit DWARF4 by default
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Ed Maste
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-01-11 21:35 UTC by Ed Maste
Modified: 2019-01-25 14:47 UTC (History)
1 user (show)

See Also:
antoine: exp-run+


Attachments
Default to DWARF4 in FreeBSD 12 and later (1.34 KB, patch)
2019-01-11 21:35 UTC, Ed Maste
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ed Maste freebsd_committer 2019-01-11 21:35:48 UTC
Created attachment 201046 [details]
Default to DWARF4 in FreeBSD 12 and later

I would like to have Clang emit DWARF4 by default and would like to see if any ports will be affected by the change.

Review: https://reviews.freebsd.org/D17930
Patch attached.
Comment 1 Antoine Brodin freebsd_committer 2019-01-25 09:25:07 UTC
Exp-run looks fine
Comment 2 commit-hook freebsd_committer 2019-01-25 14:47:14 UTC
A commit references this bug:

Author: emaste
Date: Fri Jan 25 14:46:14 UTC 2019
New revision: 343429
URL: https://svnweb.freebsd.org/changeset/base/343429

Log:
  clang: default to DWARF 4 as of FreeBSD 13

  FreeBSD previously defaulted to DWARF 2 because several tools (gdb,
  ctfconvert, etc.) did not support later versions.  These have either
  been fixed or are deprecated.

  Note that gdb 6 still exists but has been moved out of $PATH into
  /usr/libexec and is intended only for use by crashinfo(8).  The kernel
  build sets the DWARF version explicitly via -gdwarf2, so this should
  have no effect there.

  PR:		234887 [exp-run]
  Reviewed by:	markj
  Sponsored by:	The FreeBSD Foundation
  Differential Revision:	https://reviews.freebsd.org/D17930

Changes:
  head/contrib/llvm/tools/clang/lib/Driver/ToolChains/FreeBSD.cpp
  head/contrib/llvm/tools/clang/lib/Driver/ToolChains/FreeBSD.h
Comment 3 Ed Maste freebsd_committer 2019-01-25 14:47:31 UTC
Thanks for the exp-run Antoine.