Bug 234888 - ports-mgmt/portlint: overeager "WARN: Makefile: X appears in PORT_OPTIONS:M, but is not listed in OPTIONS_DEFINE"
Summary: ports-mgmt/portlint: overeager "WARN: Makefile: X appears in PORT_OPTIONS:M, ...
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Joe Marcus Clarke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-01-11 22:59 UTC by Gerald Pfeifer
Modified: 2019-01-11 22:59 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (marcus)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Gerald Pfeifer freebsd_committer 2019-01-11 22:59:34 UTC
Recently portlint started to issue the following warnings in most of my
lang/gcc* ports such as lang/gcc7:

  WARN: Makefile: MULTILIB appears in PORT_OPTIONS:M, but is not listed in   
  OPTIONS_DEFINE


If we look at lang/gcc7/Makefile we find

  OPTIONS_DEFINE=         BOOTSTRAP GRAPHITE
  :
  .if exists(/usr/lib32/libc.so)
  OPTIONS_DEFINE_powerpc64+=      MULTILIB
  :

so the later

  .if ${ARCH} == powerpc64 && ${PORT_OPTIONS:MMULTILIB}
        ${MKDIR} ${STAGEDIR}${TARGLIB32}/gcc${SUFFIX}
        ${MV} ${STAGEDIR}${PREFIX}/lib/lib32/*${STAGEDIR}${TARGLIB32}/gcc${SUFFIX}
  .endif

should be fine.  

(Well, technically the two .if-s do not feature exactly the same
condition, but I bet portlint would warn in any case.)


Suggested approach: combine the contents of *all* OPTIONS_DEFINE*
statements and use that superset for this warning.