Bug 234927 - www/py-url: fix build with GCC-based architectures
Summary: www/py-url: fix build with GCC-based architectures
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Martin Wilke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-01-13 22:54 UTC by Piotr Kubaj
Modified: 2019-01-22 13:32 UTC (History)
2 users (show)

See Also:
kai: maintainer-feedback+

Attachments
patch (351 bytes, patch)
2019-01-13 22:54 UTC, Piotr Kubaj 		no flags Details | Diff
py-url-fix-gcc-and-strip-lib.patch (614 bytes, patch)
2019-01-14 13:05 UTC, Kai Knoblich 		kai: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer freebsd_triage 2019-01-13 22:54:46 UTC 
Created attachment 201105 [details]
patch

This port requires C++11-aware compiler. Add USES=compiler:c++11-lang to fix build on GCC architectures.

Tested on powerpc64 and amd64.

Hardware sponsored by IntegriCloud.
Comment 1 Martin Wilke freebsd_committer freebsd_triage 2019-01-14 11:42:21 UTC 
Take.
Comment 2 Kai Knoblich freebsd_committer freebsd_triage 2019-01-14 13:05:48 UTC 
Created attachment 201118 [details]
py-url-fix-gcc-and-strip-lib.patch

(In reply to Piotr Kubaj from comment #0)

Thank you for the patch and your ongoing effort on the ports compliance for the PowerPC architecture.

I added the post-install target to your patch, which I initially forgot when the port was added to the ports tree.

Summarization:

- USES compiler:c++11-lang is needed to fix the build on GCC-based architectures
  such as powerpc64. [1]
- Level up port compliance further by stripping shared libraries [2]

Submitted by: Piotr Kubaj [1]
Approved by: maintainer [2]