Bug 234953 - security/cryptopp: add support for AltiVec
Summary: security/cryptopp: add support for AltiVec
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jason E. Hale
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-01-14 23:05 UTC by Piotr Kubaj
Modified: 2019-01-16 05:38 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (jhale)


Attachments
patch (1.44 KB, patch)
2019-01-14 23:05 UTC, Piotr Kubaj
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer 2019-01-14 23:05:32 UTC
Created attachment 201142 [details]
patch

Add support for building with AltiVec extensions. Note that because MACHINE_CPU is not defined on powerpc*, we rely only on ARCH.

Because of this I chose to optimize using instructions available in POWER8 and newer, so this port built with SIMD option won't work on older POWER CPU's (we could however add additional options for that, to support AltiVec in older POWER, if necessary).

Tested on powerpc64 and amd64 (with and without SIMD on both).

Hardware sponsored by IntegriCloud.
Comment 1 Piotr Kubaj freebsd_committer 2019-01-14 23:06:34 UTC
While here, also remove BROKEN on powerpc. After adding USES=compiler, powerpc64 builds, so I can see no reason why powerpc wouldn't.
Comment 2 commit-hook freebsd_committer 2019-01-16 05:38:51 UTC
A commit references this bug:

Author: linimon
Date: Wed Jan 16 05:38:28 UTC 2019
New revision: 490453
URL: https://svnweb.freebsd.org/changeset/ports/490453

Log:
  Add support for building with AltiVec extensions.  Note that because
  MACHINE_CPU is not defined on powerpc*, we rely only on ARCH.

  Because of this we choose to optimize using instructions available in
  POWER8 and newer, so this port built with SIMD option won't work on older
  POWER CPUs (we could however add additional options for that, to support
  AltiVec in older POWER, if desired).

  While here, also remove BROKEN on powerpc.

  PR:		234953
  Submitted by:	Piotr Kubaj
  Approved by:	portmgr (tier-2 blanket)

Changes:
  head/security/cryptopp/Makefile