Bug 235045 - devel/git: git-p4 shebang mangled
Summary: devel/git: git-p4 shebang mangled
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Renato Botelho
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-01-18 12:24 UTC by John Hein
Modified: 2019-02-25 13:23 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (garga)

Attachments
[patch] fix git-p4 shebang (646 bytes, patch)
2019-01-18 12:24 UTC, John Hein 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Hein 2019-01-18 12:24:56 UTC 
Created attachment 201233 [details]
[patch] fix git-p4 shebang

The shebang for the installed git-p4 script is mangled like so:

#!/usr/local/bin/python2.72.7

Mk/Scripts/qa.sh doesn't notice because it is overly narrow it the python spelling violations it looks for (one could submit a separate bug to improve that).

See attached patch.  This could be submitted upstream.

QA:
 poudriere testport - ok
 portlint - no change (note: it looks like 'USES=iconv twice' warning is a valid problem)
Comment 1 commit-hook freebsd_committer freebsd_triage 2019-02-25 13:22:27 UTC 
A commit references this bug:

Author: garga
Date: Mon Feb 25 13:22:20 UTC 2019
New revision: 493857
URL: https://svnweb.freebsd.org/changeset/ports/493857

Log:
  - Update devel/git to 2.21.0 [1]
  - Fix git-p4 shebang [2]

  PR:		236020 [1] (based on), 235045 [2]
  Submitted by:	Yasuhiro KIMURA <yasu@utahime.org> [1]
  		John Hein <jcfyecrayz@liamekaens.com> [2]
  Sponsored by:	Rubicon Communications, LLC (Netgate)

Changes:
  head/devel/git/Makefile
  head/devel/git/distinfo
  head/devel/git/files/patch-Makefile
  head/devel/git/pkg-plist