Created attachment 201254 [details] patch for version 0.2.5 of git-secret git-secret is a tool which stores private data inside a git repo. General information: git-secret encrypts tracked files with public keys for users whom you trust using gpg, allowing permitted users to access encrypted data using their secret keys. QA: * https://travis-ci.org/sobolevn/git-secret/pull_requests Additional details: * The port was developed with the assistance of @lrosenman and @mvanbaak . The original PR can be seen here: https://github.com/joshrabinowitz/freebsd-ports/pull/1 And you can see support for FreeBSD added to git-secret here: https://github.com/sobolevn/git-secret/pull/260 * @lrosenman said: "Feel free to assign me (ler@FreeBSD.org) the bug when you submit", but I don't think I can assign bugs to people.
Created attachment 201256 [details] improved patch for git-secret 0.2.5 improved patch for git-secret 0.2.5, records runtime dependency on bash.
Thanks! Last patch has the README and NOTES included. Can you upload a patch without them like the first one please? Thanks! Looks good. Good job!
Created attachment 201261 [details] improved patch for git-secret 0.2.5 without extra files as requested... thank you!
Can you alphabetize RUN_DEPENDS, please? Then I'll commit it.
Created attachment 201262 [details] patch for git-secret 0.2.5, files and packages sorted sorted RUN_DEPENDS entries, and sorted pkg-plist by filenames.
Committed, thanks. I added NO_ARCH=yes as this port is all shell scripts.
A commit references this bug: Author: ler Date: Sat Jan 19 03:01:20 UTC 2019 New revision: 490698 URL: https://svnweb.freebsd.org/changeset/ports/490698 Log: security/git-secret: New Port. git-secret is a tool which stores private data inside a git repo. General information: git-secret encrypts tracked files with public keys for users whom you trust using gpg, allowing permitted users to access encrypted data using their secret keys. PR: 235056 Submitted by: joshr-freebsd@joshr.com Changes: head/security/Makefile head/security/git-secret/ head/security/git-secret/Makefile head/security/git-secret/distinfo head/security/git-secret/pkg-descr head/security/git-secret/pkg-plist
Why such a weird pkg-plist?
(In reply to Alex Dupre from comment #8) Alex - what is weird about the pkg-plist?
The prefix of all file entries with "@(root,root,nnn) "
(In reply to Alex Dupre from comment #10) It's a way of setting the ownership and permissions on the installed files. portlint suggested the change after I was trying to use ${CHMOD}.
There is no reason to change the ownership and permissions, when you use the ${INSTALL_xxx} commands the FreeBSD port framework already sets the correct ones.
(In reply to Alex Dupre from comment #12) ah, I suppose it's a little redundant then. Seems ok for now though, let's revisit if desired on next update.