Bug 235056 - [new port] security/git-secret: tool for storing secret data in a git repo using gpg
Summary: [new port] security/git-secret: tool for storing secret data in a git repo us...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Larry Rosenman
URL: http://git-secret.io
Keywords: feature, security
Depends on:
Blocks:
 
Reported: 2019-01-18 23:07 UTC by Josh Rabinowitz
Modified: 2019-01-19 12:49 UTC (History)
4 users (show)

See Also:


Attachments
patch for version 0.2.5 of git-secret (3.12 KB, patch)
2019-01-18 23:07 UTC, Josh Rabinowitz
no flags Details | Diff
improved patch for git-secret 0.2.5 (6.25 KB, patch)
2019-01-18 23:38 UTC, Josh Rabinowitz
no flags Details | Diff
improved patch for git-secret 0.2.5 without extra files (3.11 KB, patch)
2019-01-19 01:45 UTC, Josh Rabinowitz
no flags Details | Diff
patch for git-secret 0.2.5, files and packages sorted (3.11 KB, patch)
2019-01-19 02:25 UTC, Josh Rabinowitz
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Josh Rabinowitz 2019-01-18 23:07:53 UTC
Created attachment 201254 [details]
patch for version 0.2.5 of git-secret

git-secret is a tool which stores private data inside a git repo.

General information:

git-secret encrypts tracked files with public keys for users whom you trust using gpg, allowing permitted users to access encrypted data using their secret keys. 

QA:

* https://travis-ci.org/sobolevn/git-secret/pull_requests

Additional details:

* The port was developed with the assistance of @lrosenman and @mvanbaak . The original PR can be seen here:

https://github.com/joshrabinowitz/freebsd-ports/pull/1

And you can see support for FreeBSD added to git-secret here:

https://github.com/sobolevn/git-secret/pull/260

* @lrosenman said: "Feel free to assign me (ler@FreeBSD.org) the bug when you submit", but I don't think I can assign bugs to people.
Comment 1 Josh Rabinowitz 2019-01-18 23:38:10 UTC
Created attachment 201256 [details]
improved patch for git-secret 0.2.5

improved patch for git-secret 0.2.5, records runtime dependency on bash.
Comment 2 Michiel van Baak 2019-01-19 00:38:38 UTC
Thanks!

Last patch has the README and NOTES included. Can you upload a patch without them like the first one please?
Thanks!

Looks good. Good job!
Comment 3 Josh Rabinowitz 2019-01-19 01:45:04 UTC
Created attachment 201261 [details]
improved patch for git-secret 0.2.5 without extra files

as requested... thank you!
Comment 4 Larry Rosenman freebsd_committer 2019-01-19 02:04:27 UTC
Can you alphabetize RUN_DEPENDS, please?  Then I'll commit it.
Comment 5 Josh Rabinowitz 2019-01-19 02:25:02 UTC
Created attachment 201262 [details]
patch for git-secret 0.2.5, files and packages sorted

sorted RUN_DEPENDS entries, and sorted pkg-plist by filenames.
Comment 6 Larry Rosenman freebsd_committer 2019-01-19 03:02:00 UTC
Committed, thanks. 

I added NO_ARCH=yes as this port is all shell scripts.
Comment 7 commit-hook freebsd_committer 2019-01-19 03:03:00 UTC
A commit references this bug:

Author: ler
Date: Sat Jan 19 03:01:20 UTC 2019
New revision: 490698
URL: https://svnweb.freebsd.org/changeset/ports/490698

Log:
  security/git-secret: New Port.

  git-secret is a tool which stores private data inside a git repo.

  General information:

  git-secret encrypts tracked files with public keys for users whom you trust using gpg, allowing permitted users to access encrypted data using their secret keys.

  PR:		235056
  Submitted by:	joshr-freebsd@joshr.com

Changes:
  head/security/Makefile
  head/security/git-secret/
  head/security/git-secret/Makefile
  head/security/git-secret/distinfo
  head/security/git-secret/pkg-descr
  head/security/git-secret/pkg-plist
Comment 8 Alex Dupre freebsd_committer 2019-01-19 09:12:27 UTC
Why such a weird pkg-plist?
Comment 9 Josh Rabinowitz 2019-01-19 11:33:52 UTC
(In reply to Alex Dupre from comment #8)

Alex - what is weird about the pkg-plist?
Comment 10 Alex Dupre freebsd_committer 2019-01-19 11:40:30 UTC
The prefix of all file entries with "@(root,root,nnn) "
Comment 11 Josh Rabinowitz 2019-01-19 11:56:32 UTC
(In reply to Alex Dupre from comment #10)

It's a way of setting the ownership and permissions on the installed files. 

portlint suggested the change after I was trying to use ${CHMOD}.
Comment 12 Alex Dupre freebsd_committer 2019-01-19 12:44:42 UTC
There is no reason to change the ownership and permissions, when you use the ${INSTALL_xxx} commands the FreeBSD port framework already sets the correct ones.
Comment 13 Josh Rabinowitz 2019-01-19 12:49:00 UTC
(In reply to Alex Dupre from comment #12)
ah, I suppose it's a little redundant then. 
Seems ok for now though, let's revisit if desired on next update.