Bug 235093 - x11/kde5: more GCC fixes
Summary: x11/kde5: more GCC fixes
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: kde
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-01-20 23:08 UTC by Piotr Kubaj
Modified: 2019-02-18 21:23 UTC (History)
4 users (show)

See Also:
tcberner: maintainer-feedback+


Attachments
patch (5.33 KB, patch)
2019-01-20 23:08 UTC, Piotr Kubaj
no flags Details | Diff
v2 (6.55 KB, patch)
2019-01-21 17:04 UTC, Piotr Kubaj
no flags Details | Diff
v3 (7.30 KB, patch)
2019-01-29 08:41 UTC, Piotr Kubaj
no flags Details | Diff
v4 (12.71 KB, patch)
2019-01-31 07:44 UTC, Piotr Kubaj
no flags Details | Diff
new fixes (3.75 KB, patch)
2019-02-11 10:51 UTC, Piotr Kubaj
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj 2019-01-20 23:08:17 UTC
Created attachment 201300 [details]
patch

Add USES=compiler:c++11-lang where it's needed and use webengine only on amd64 and i386 if the port compiles without it.

Tested on powerpc64 and amd64.

Hardware sponsored by IntegriCloud.
Comment 1 Tobias C. Berner freebsd_committer 2019-01-21 05:21:39 UTC
Moin moin

x11-toolkits/plasma5-kdeplasma-addons misses the options definitions, and will require an explicit toggle to CMake so it is not accidentally linked against.


mfg Tobias
Comment 2 Piotr Kubaj 2019-01-21 17:04:40 UTC
Created attachment 201313 [details]
v2

Is that ok?
Comment 3 Tobias C. Berner freebsd_committer 2019-01-27 16:17:26 UTC
Moin moin

Could you refresh the patch against the current tree?


mfg Tobias
Comment 4 Piotr Kubaj 2019-01-29 08:41:42 UTC
Created attachment 201499 [details]
v3

Regenerated.
Comment 5 Piotr Kubaj 2019-01-31 07:44:35 UTC
Created attachment 201551 [details]
v4

Add option to build qtcreator without qt5-webengine.
Comment 6 commit-hook freebsd_committer 2019-02-08 22:51:02 UTC
A commit references this bug:

Author: tcberner
Date: Fri Feb  8 22:50:26 UTC 2019
New revision: 492466
URL: https://svnweb.freebsd.org/changeset/ports/492466

Log:
  Fix with build on GCC architectures.

  PR:		235093
  Submitted by:	Piotr Kubaj <pkubaj@anongoth.pl>

Changes:
  head/audio/juk/Makefile
  head/databases/kexi/Makefile
  head/games/knights/Makefile
  head/games/ksudoku/Makefile
  head/graphics/kphotoalbum/Makefile
  head/graphics/showimage/Makefile
  head/multimedia/kaffeine/Makefile
  head/multimedia/phonon-gstreamer/Makefile
  head/x11/yakuake/Makefile
  head/x11-fm/krusader2/Makefile
Comment 7 Tobias C. Berner freebsd_committer 2019-02-08 22:52:12 UTC
Sorry for the timeout :) first batch committed...
Comment 8 Piotr Kubaj 2019-02-11 10:51:34 UTC
Created attachment 201927 [details]
new fixes

More fixes (in addition to the older patch).
Comment 9 commit-hook freebsd_committer 2019-02-18 17:59:41 UTC
A commit references this bug:

Author: adridg
Date: Mon Feb 18 17:59:18 UTC 2019
New revision: 493281
URL: https://svnweb.freebsd.org/changeset/ports/493281

Log:
  More non-clang, non-x86 fixes.

   - add compiler:c++11-lang
   - make WebEngine optional

  (Second batch of fixes from the same PR)

  PR:		235093
  Submitted by:	Piotr Kubaj <pkubaj@anongoth.pl>

Changes:
  head/audio/amarok/Makefile
  head/audio/amarok/pkg-plist
  head/games/gcompris-qt/Makefile
  head/multimedia/kamoso/Makefile
Comment 10 Adriaan de Groot freebsd_committer 2019-02-18 21:23:53 UTC
First commit added a bogus =true. That was removed in r493318. Thanks for submitting the patches.