Bug 235111 - add bectl support to beinstall.sh
Summary: add bectl support to beinstall.sh
Status: In Progress
Alias: None
Product: Base System
Classification: Unclassified
Component: misc (show other bugs)
Version: 12.0-RELEASE
Hardware: Any Any
: --- Affects Some People
Assignee: Mateusz Piotrowski
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-01-21 15:46 UTC by Olivier Cochard
Modified: 2020-10-25 15:01 UTC (History)
4 users (show)

See Also:


Attachments
patch to add bectl support (2.96 KB, patch)
2019-01-21 15:46 UTC, Olivier Cochard
no flags Details | Diff
patch to add bectl support and update man page (3.59 KB, patch)
2019-01-21 16:10 UTC, Olivier Cochard
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Cochard freebsd_committer 2019-01-21 15:46:18 UTC
Created attachment 201310 [details]
patch to add bectl support

beadm seems deprecated toward bectl, so here is a patch to add both support into beinstall.sh
Comment 1 Mateusz Piotrowski freebsd_committer 2019-01-21 15:48:28 UTC
Remember to update the manual page as well!
Comment 2 Olivier Cochard freebsd_committer 2019-01-21 16:10:20 UTC
Created attachment 201311 [details]
patch to add bectl support and update man page

Here is the updated patch including man page update. I've removed reference to beadm into the man page to simplify it (even if the script still support it). This tool was added into FreeBSD 12.0, like bectl, so I don't think it's a problem to remove beadm reference.
Comment 3 Olivier Cochard freebsd_committer 2019-02-22 19:32:04 UTC
Can an src committer push or approve it?
Comment 4 Mateusz Piotrowski freebsd_committer 2020-10-25 11:27:06 UTC
Note: I've totally forgot about this PR and submitted my own patch a couple of months later to phabricator:
https://reviews.freebsd.org/D21111
Comment 5 Olivier Cochard freebsd_committer 2020-10-25 11:49:51 UTC
So let's abandon this PR and focus on your review :-)
Comment 6 Mateusz Piotrowski freebsd_committer 2020-10-25 15:01:36 UTC
(In reply to Olivier Cochard from comment #5)

OK :)